Received-SPF: pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Message-ID: <6d2d94e01552f5713266add9e4909c85266e53ab.camel@sipsolutions.net>
Subject: Re: [PATCH] cfg80211: Enhance the AKM advertizement to support per
 interface.
From:   Johannes Berg <johannes@sipsolutions.net>
To:     Veerendranath Jakkam <vjakkam@codeaurora.org>
Cc:     linux-wireless@vger.kernel.org
Date:   Thu, 02 Jan 2020 14:41:44 +0100
In-Reply-To: <20191223185255.1009-1-vjakkam@codeaurora.org>
References: <20191223185255.1009-1-vjakkam@codeaurora.org>
Content-Type: text/plain; charset="UTF-8"
User-Agent: Evolution 3.34.2 (3.34.2-1.fc31) 
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-wireless-owner@vger.kernel.org
Precedence: bulk

On Tue, 2019-12-24 at 00:22 +0530, Veerendranath Jakkam wrote:
> 
> @@ -2437,10 +2472,8 @@ static int nl80211_send_wiphy(struct cfg80211_registered_device *rdev,
>  		state->split_start++;
>  		break;
>  	case 15:
> -		if (rdev->wiphy.akm_suites &&
> -		    nla_put(msg, NL80211_ATTR_AKM_SUITES,
> -			    sizeof(u32) * rdev->wiphy.n_akm_suites,
> -			    rdev->wiphy.akm_suites))

I don't think you should break this for all existing cases.

johannes