Received-SPF: pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Toke =?utf-8?Q?H=C3=B8iland-J=C3=B8rgensen?= <toke@redhat.com>
To:     Markus Theil <markus.theil@tu-ilmenau.de>,
        johannes@sipsolutions.net
Cc:     linux-wireless@vger.kernel.org
Subject: Re: [PATCH] iw: info: print missing extended feature flag information
In-Reply-To: <0e8cd8ee-e9c3-2b0a-bdce-f831367734a1@tu-ilmenau.de>
References: <20200101174836.5513-1-markus.theil@tu-ilmenau.de> <8736csltrb.fsf@toke.dk> <0e8cd8ee-e9c3-2b0a-bdce-f831367734a1@tu-ilmenau.de>
Date:   Mon, 06 Jan 2020 12:42:09 +0100
Message-ID: <87zhf0ke0e.fsf@toke.dk>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Sender: linux-wireless-owner@vger.kernel.org
Precedence: bulk

Markus Theil <markus.theil@tu-ilmenau.de> writes:

> On 1/6/20 12:16 PM, Toke H=C3=B8iland-J=C3=B8rgensen wrote:
>> Markus Theil <markus.theil@tu-ilmenau.de> writes:
>>
>>> Some extended feature flags were not considered before.
>>>
>>> Signed-off-by: Markus Theil <markus.theil@tu-ilmenau.de>
>>> ---
>>>  info.c | 10 ++++++++++
>>>  1 file changed, 10 insertions(+)
>>>
>>> diff --git a/info.c b/info.c
>>> index 38362d8..0f24dae 100644
>>> --- a/info.c
>>> +++ b/info.c
>>> @@ -676,7 +676,17 @@ broken_combination:
>>>  		ext_feat_print(tb, DFS_OFFLOAD, "DFS offload");
>>>  		ext_feat_print(tb, CONTROL_PORT_OVER_NL80211,
>>>  			       "control port over nl80211");
>>> +		ext_feat_print(tb, ACK_SIGNAL_SUPPORT,
>>> +			       "ack signal level support");
>>>  		ext_feat_print(tb, TXQS, "FQ-CoDel-enabled intermediate TXQs");
>>> +		ext_feat_print(tb, SCAN_RANDOM_SN,
>>> +			       "use random sequence numbers in scans");
>>> +		ext_feat_print(tb, SCAN_MIN_PREQ_CONTENT,
>>> +			       "use probe request with only rate IEs in scans");
>>> +		ext_feat_print(tb, CAN_REPLACE_PTK0,
>>> +			       "can safely replace PTK 0 when rekeying");
>>> +		ext_feat_print(tb, ENABLE_FTM_RESPONDER,
>>> +			       "enable FTM (Fine Time Measurement) responder");
>>>  		ext_feat_print(tb, AIRTIME_FAIRNESS,
>>>  			       "airtime fairness scheduling");
>> I would prefer to keep TXQS and AIRTIME_FAIRNESS next to each other.
>>
>> Also, while you're at it, could you please add the newly-added AQL
>> feature? Something like
>>
>>   		ext_feat_print(tb, AIRTIME_FAIRNESS,
>>   			       "airtime fairness scheduling");
>>  +		ext_feat_print(tb, AQL,
>>  +			       "Airtime Queue Limits (AQL)");
> I'm currently working on some other small patches and will include this
> and reorder the flags such that TXQS and AIRTIME_FAIRNESS will be next
> to each other.
> Thanks for the hint!

Great, thanks! :)

-Toke