Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp667286ybl; Wed, 8 Jan 2020 03:58:21 -0800 (PST) X-Google-Smtp-Source: APXvYqxK83+azdqmVeGpKqft5vzbSuChiTym2FFCrUOPpENFlknzPl1MB8AcMVsk0UIZ5FkmzU9C X-Received: by 2002:a9d:4817:: with SMTP id c23mr3727361otf.59.1578484701832; Wed, 08 Jan 2020 03:58:21 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1578484701; cv=none; d=google.com; s=arc-20160816; b=qWoK2Sa3QgB7LkOUAtIfkwdWXFvb6lJg3lmaPvpjv8q6yWUGkODGORkjEi+Lq7uItz gXr9dwmiBHSYXXFKNjmJvxuVVQiVB0QsCEZFRBWuslkzuijv3fogXHx5xrSqeKjCPaKv MzfnLT7K9nYRyp+Oi+pvEJSeFC4OacYcldwMIcYtnPnT/3h62r4KkCJnerU94+Z7z+QL KfAoxJcVW65uety2l2yP4zgAR0VPvFhKCczAIlnbw7aV0f+z8JPkf3gEdxX9EfwxESZG ceYtHSYiGXuu2DZcr4UN6CxI7vZArLgAgP24c8d2oYkvJ6s3TkPxpDx8MjYQyXXfWHOc POHA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=mBgEv51TLEef3clRg3xCokeSCc1ExtA/8nyEowoXQG4=; b=yPmtGhgU4Rh5cXUyVWRwf620IIEmt3Sl4ed29jpk1e0xsyQFltAhgJAJ+OLS/YqAEN IjDWgZbOc8Eu8i57glm2HH6KGNiOjMjRCuXs7lc+fgPvY2u5rVOE93H3RMR6xuFqJCjF kUK/FlGFN04aZ9jgSL3cLk7FXfeUUTd4ko72Ljpx4rwzM6//D97MLwbKm/JUTHncZBO5 gTP3cPEY6UepeV2qMbm5jwwo1lBU4Q0/dQOS2MWRyvpXgJY0QOkVdITyUUhHSr2SLsrr dzyVZDIKj5tRFj8AZqqogiQH/42iZ6+K+qmq8SFezE9Ke/HJa/qdv+X58c4bSGRNrhOX k4xw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id j24si1592374otn.110.2020.01.08.03.58.03; Wed, 08 Jan 2020 03:58:21 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727236AbgAHLzl (ORCPT + 99 others); Wed, 8 Jan 2020 06:55:41 -0500 Received: from smail.rz.tu-ilmenau.de ([141.24.186.67]:50295 "EHLO smail.rz.tu-ilmenau.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727207AbgAHLzl (ORCPT ); Wed, 8 Jan 2020 06:55:41 -0500 Received: from localhost.localdomain (unknown [141.24.207.101]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smail.rz.tu-ilmenau.de (Postfix) with ESMTPSA id 6A8CC58006C; Wed, 8 Jan 2020 12:55:39 +0100 (CET) From: Markus Theil To: johannes@sipsolutions.net Cc: linux-wireless@vger.kernel.org, Markus Theil , stable@vger.kernel.org Subject: [PATCH] cfg80211: fix deadlocks in autodisconnect work Date: Wed, 8 Jan 2020 12:55:36 +0100 Message-Id: <20200108115536.2262-1-markus.theil@tu-ilmenau.de> X-Mailer: git-send-email 2.24.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Use methods which do not try to acquire the wdev lock themselves. Cc: stable@vger.kernel.org Fixes: 37b1c004685a3 ("cfg80211: Support all iftypes in autodisconnect_wk") Signed-off-by: Markus Theil --- net/wireless/sme.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/net/wireless/sme.c b/net/wireless/sme.c index 7a6c38ddc65a..d32a2ec4d96a 100644 --- a/net/wireless/sme.c +++ b/net/wireless/sme.c @@ -1307,14 +1307,14 @@ void cfg80211_autodisconnect_wk(struct work_struct *work) if (wdev->conn_owner_nlportid) { switch (wdev->iftype) { case NL80211_IFTYPE_ADHOC: - cfg80211_leave_ibss(rdev, wdev->netdev, false); + __cfg80211_leave_ibss(rdev, wdev->netdev, false); break; case NL80211_IFTYPE_AP: case NL80211_IFTYPE_P2P_GO: - cfg80211_stop_ap(rdev, wdev->netdev, false); + __cfg80211_stop_ap(rdev, wdev->netdev, false); break; case NL80211_IFTYPE_MESH_POINT: - cfg80211_leave_mesh(rdev, wdev->netdev); + __cfg80211_leave_mesh(rdev, wdev->netdev); break; case NL80211_IFTYPE_STATION: case NL80211_IFTYPE_P2P_CLIENT: -- 2.24.1