Received-SPF: pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org C8759C433A2
From:   Kalle Valo <kvalo@codeaurora.org>
To:     Denis Kalashnikov <denis281089@gmail.com>
Cc:     linux-wireless@vger.kernel.org
Subject: Re: [PATCH 1/1] ath9k: fix firmware bug in some of Mikrotik R11e-2HPnD cards
References: <CAKoLU8M+QU-96vnfet-759nnXyxxJmsf1Csba4FgNas8ZVOnOQ@mail.gmail.com>
Date:   Fri, 10 Jan 2020 10:27:12 +0200
In-Reply-To: <CAKoLU8M+QU-96vnfet-759nnXyxxJmsf1Csba4FgNas8ZVOnOQ@mail.gmail.com>
        (Denis Kalashnikov's message of "Fri, 27 Dec 2019 10:18:05 +0300")
Message-ID: <87v9pjsom7.fsf@codeaurora.org>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
Sender: linux-wireless-owner@vger.kernel.org
Precedence: bulk

Denis Kalashnikov <denis281089@gmail.com> writes:

> Some of the Mikrotik R11e-2HPnD cards have EEPROM where is
> flashed that a card has 3 chains, but actually all this cards
> have only 2. This leads ath9k to write periodically into the logs:
> 'ath: phy0: Unable to reset channel, reset status -5' and
> stations don't see that AP.
>
> Mikrotik R11e-2HPnD is based on AR9582 chip.
>
> Signed-off-by: Denis Kalashnikov <denis281089@gmail.com>
> ---
>  drivers/net/wireless/ath/ath9k/ar9003_eeprom.c | 9 +++++++++
>  1 file changed, 9 insertions(+)
>
> diff --git a/drivers/net/wireless/ath/ath9k/ar9003_eeprom.c
> b/drivers/net/wireless/ath/ath9k/ar9003_eeprom.c
> index b4885a700296..554a81400648 100644
> --- a/drivers/net/wireless/ath/ath9k/ar9003_eeprom.c
> +++ b/drivers/net/wireless/ath/ath9k/ar9003_eeprom.c
> @@ -3373,6 +3373,15 @@ static int
> ar9300_eeprom_restore_internal(struct ath_hw *ah,
>                 cptr -= (COMP_HDR_LEN + osize + COMP_CKSUM_LEN);
>         }
>
> +       /**
> +        * Fix firmware bug of some Mikrotik R11e-2HPnD cards (based on AR9582)
> +        * that claim that they have 3 chains, but actually have only 2.
> +        */
> +       if (AR_SREV_9580(ah)) {
> +               eep = (struct ar9300_eeprom *)mptr;
> +               eep->baseEepHeader.txrxMask &= 0x33;
> +       }

What about 9580 devices which really have 3 chains, doesn't this broke
those? Or is such setup impossible?

-- 
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches