Received-SPF: pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <CAKoLU8M+QU-96vnfet-759nnXyxxJmsf1Csba4FgNas8ZVOnOQ@mail.gmail.com>
 <87v9pjsom7.fsf@codeaurora.org>
In-Reply-To: <87v9pjsom7.fsf@codeaurora.org>
From:   Denis Kalashnikov <denis281089@gmail.com>
Date:   Fri, 10 Jan 2020 14:37:23 +0300
Message-ID: <CAKoLU8Oft1Lu1fQx2wRyO8nfOuynu6Ns5=xdq+j2X-wyyzYV9w@mail.gmail.com>
Subject: Re: [PATCH 1/1] ath9k: fix firmware bug in some of Mikrotik
 R11e-2HPnD cards
To:     Kalle Valo <kvalo@codeaurora.org>
Cc:     linux-wireless@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Sender: linux-wireless-owner@vger.kernel.org
Precedence: bulk

You are right, it is possible. I will fix my patch and resend. Thank you.

=D0=BF=D1=82, 10 =D1=8F=D0=BD=D0=B2. 2020 =D0=B3. =D0=B2 11:27, Kalle Valo =
<kvalo@codeaurora.org>:
>
> Denis Kalashnikov <denis281089@gmail.com> writes:
>
> > Some of the Mikrotik R11e-2HPnD cards have EEPROM where is
> > flashed that a card has 3 chains, but actually all this cards
> > have only 2. This leads ath9k to write periodically into the logs:
> > 'ath: phy0: Unable to reset channel, reset status -5' and
> > stations don't see that AP.
> >
> > Mikrotik R11e-2HPnD is based on AR9582 chip.
> >
> > Signed-off-by: Denis Kalashnikov <denis281089@gmail.com>
> > ---
> >  drivers/net/wireless/ath/ath9k/ar9003_eeprom.c | 9 +++++++++
> >  1 file changed, 9 insertions(+)
> >
> > diff --git a/drivers/net/wireless/ath/ath9k/ar9003_eeprom.c
> > b/drivers/net/wireless/ath/ath9k/ar9003_eeprom.c
> > index b4885a700296..554a81400648 100644
> > --- a/drivers/net/wireless/ath/ath9k/ar9003_eeprom.c
> > +++ b/drivers/net/wireless/ath/ath9k/ar9003_eeprom.c
> > @@ -3373,6 +3373,15 @@ static int
> > ar9300_eeprom_restore_internal(struct ath_hw *ah,
> >                 cptr -=3D (COMP_HDR_LEN + osize + COMP_CKSUM_LEN);
> >         }
> >
> > +       /**
> > +        * Fix firmware bug of some Mikrotik R11e-2HPnD cards (based on=
 AR9582)
> > +        * that claim that they have 3 chains, but actually have only 2=
.
> > +        */
> > +       if (AR_SREV_9580(ah)) {
> > +               eep =3D (struct ar9300_eeprom *)mptr;
> > +               eep->baseEepHeader.txrxMask &=3D 0x33;
> > +       }
>
> What about 9580 devices which really have 3 chains, doesn't this broke
> those? Or is such setup impossible?
>
> --
> https://wireless.wiki.kernel.org/en/developers/documentation/submittingpa=
tches