Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp3849662ybl; Mon, 13 Jan 2020 03:47:47 -0800 (PST) X-Google-Smtp-Source: APXvYqwJTSBxUCzKEhBR9GWOCxhRFMZuC8lQb7SQdT/Z3IBtKN96I41hGVeSCEHQy3igzYXHvDC/ X-Received: by 2002:a9d:12a8:: with SMTP id g37mr13017598otg.261.1578916067530; Mon, 13 Jan 2020 03:47:47 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1578916067; cv=none; d=google.com; s=arc-20160816; b=oPqYh8muWrn8ke7mJWpOMjzywAYzEweR1YdKchs5Nwj3LwleM1frSLMeCjFVIY4Fsr TRAxcWe0BD8wQaeqY5guf8EJjs2ggzkg46Liv+vTXvP5P4WZf2MfrToX6NoWA6nyR5LV q9JoAODycLDRHYOWl/xVmsgDbJ4nrTTVIsS1gFV8JhpkaJBPm8waoIn09Uoyjktt/slt aEv/tMpCqiIFLIAJtMuwAsFYCm9hL2Vi2AmuT60/nXdMoeW7PjmuPmyliwAl4fqaFI3X mTeh2AKaj1ivMrHlsqaqaAxHqItql1uSMlEW7JfxtGQgBFks2Ie1lXtcCjAKAMI3Whgu eQYA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-language :content-transfer-encoding:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject:dkim-signature; bh=j25aHBrSp+PLnNYwGkDcs4cVtf83TIUnbNmAIRsjS30=; b=G1z+UHmsxS2tukyCk0J0yFBmDDYJdOtyMBgmPxLytSokGaAqPYaIeaImbMAX1rXrhv pApSVKIsc8twGVLuLlFLwOLOQRuUxGpKFNKU2ReuKUv3ePb7defdX3hdgQ5oZ4SDdMa1 oKW7Yic6mw1FdlP241O0WoLNyAe9+C+Qh6AwDomZdmAngWlVu6oIuAQrTObFt/JMsmBs EBB7YNksLxydsWaAb+GNnQMGvcF8CA57ZIjunAP/BgA0mZ08fKd2ycme5zm4J9F+YMNk Jo1ju5npmfcPShtQN/bjAcjrhpH44SxH+s8nLGnY422kKeejh9v4TWqoB657a1BWlszX O/Mw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@ncentric-com.20150623.gappssmtp.com header.s=20150623 header.b=VgTqATzr; spf=pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=ncentric.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id i6si7346657otj.24.2020.01.13.03.47.27; Mon, 13 Jan 2020 03:47:47 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@ncentric-com.20150623.gappssmtp.com header.s=20150623 header.b=VgTqATzr; spf=pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=ncentric.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728757AbgAMLp3 (ORCPT + 99 others); Mon, 13 Jan 2020 06:45:29 -0500 Received: from mail-wr1-f66.google.com ([209.85.221.66]:34045 "EHLO mail-wr1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728755AbgAMLp3 (ORCPT ); Mon, 13 Jan 2020 06:45:29 -0500 Received: by mail-wr1-f66.google.com with SMTP id t2so8247884wrr.1 for ; Mon, 13 Jan 2020 03:45:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ncentric-com.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding:content-language; bh=j25aHBrSp+PLnNYwGkDcs4cVtf83TIUnbNmAIRsjS30=; b=VgTqATzrt4L2HUHFPg2Jc/sxNNwnyFyZ0GQz0luk/jgQoXAR+k12ihlHinHScYcIew tYVg8MkHAn4cuB3FzYw71x8L5ByndFd32BTb9Y4YPElE7kLSnQv0ZRlIx8cDh5TZwa1C e+57il2Yb7TIzMpXvV/VO8G8VmEyFjK0c4ldGe5XbX+Yw5Hy97jt8qj0OviDpbpXIVGf rmaLFq0cJwmbzLHolRvawypVYWZ0GvRM5BVMVxO3flcB5EQ10dEswIHBGxAg9CyVAhMA EFlOYCML2jm7L9QJNnHdclaCTTlkRof0x+CrdcG4q5/kW6r87ddNAgeaCWqMNouP0SUM sDng== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=j25aHBrSp+PLnNYwGkDcs4cVtf83TIUnbNmAIRsjS30=; b=oCyXvZ0a9vjol8lsrUeB1hw/WrtdhlDtjIcCOH7IRP0Qpervmq5+/t8kkw6+sLYv1U qWWLJIHC9Sh3Um+1iqj7iv1E01P/tttEGLUvz8WNMQOkjROVgRI5ghvezuRqxBilABAh 1U9/lrfEHwFK5n+klSgc5bSL1vayxc9J2aFpK6O6v5qvQ/aW2GXTur5YWEqj5hg7FV91 fouM30klHZR21Zj5N3297L0EgFPzoAzLdMGN2RgC9K22+DTK4WibxoGkZCM9SCFWgcmL Tc8ZWh2io3eEfLpN5wA+ec3z4fkcSwcpAbe0Wz86QiDjjLyPGaedr/EIDd4V+SScEgX8 8RtA== X-Gm-Message-State: APjAAAVJJL4vQHDis17O8e2cTVskUBLfBtztCXfuq67UAesk9ac7AXkm vcwPCpotw1hxiJPzk0kvc8UwzA== X-Received: by 2002:adf:e74a:: with SMTP id c10mr17529362wrn.386.1578915926630; Mon, 13 Jan 2020 03:45:26 -0800 (PST) Received: from [10.202.0.7] (d5152e8e2.static.telenet.be. [81.82.232.226]) by smtp.gmail.com with ESMTPSA id n14sm13469749wmi.26.2020.01.13.03.45.25 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 13 Jan 2020 03:45:25 -0800 (PST) Subject: Re: [PATCH v2 0/2] Allow userspace to reset IBSS stations to fix aggregation issue To: Nicolas Cavallari , Johannes Berg Cc: linux-wireless@vger.kernel.org, =?UTF-8?Q?Krzysztof_Ha=c5=82asa?= References: <20200103103457.22778-1-nicolas.cavallari@green-communications.fr> From: Koen Vandeputte Message-ID: Date: Mon, 13 Jan 2020 12:45:25 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.2.2 MIME-Version: 1.0 In-Reply-To: <20200103103457.22778-1-nicolas.cavallari@green-communications.fr> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org On 03.01.20 11:34, Nicolas Cavallari wrote: > I encountered the same issue in an IBSS-RSN network, where quick reboot > of a station would cause issues with aggregation because the kernel is > not aware of the reboot. > > I figured out that since wpa_supplicant already detect reboots, the > simplest way to fix it would be for wpa_supplicant to reset the entire > state of the station in the kernel, instead of just resetting keys and > port. > > This means extending NL80211_CMD_DEL_STATION to work in IBSS mode too, > just like it does in mesh point mode. > > Changes: > v2: Use a nl80211 feature flag instead of patching every driver. > > I'm more than happy to give this a thorough test on dozens of devices offshore which I suspect are suffering from this issue as they sail in-out of range, but as a new flag is defined in nl80211.h, is anything additional required at wpa_sup side to use this? If yes, please also provide a patch for that to me directly. (based on >= v2.9) Thanks, Koen