Received-SPF: pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Tue, 14 Jan 2020 15:31:09 +0300
From:   Sergey Matyukevich <sergey.matyukevich.os@quantenna.com>
To:     Tamizh Chelvam <tamizhr@codeaurora.org>
CC:     johannes@sipsolutions.net, linux-wireless@vger.kernel.org
Subject: Re: [PATCHv9 5/6] nl80211: Add support to configure TID specific
 txrate configuration
Message-ID: <20200114123108.5mrzvyqkjp7defln@bars>
Mail-Followup-To: Tamizh Chelvam <tamizhr@codeaurora.org>,
        johannes@sipsolutions.net, linux-wireless@vger.kernel.org
References: <1578921090-9758-1-git-send-email-tamizhr@codeaurora.org>
 <1578921090-9758-6-git-send-email-tamizhr@codeaurora.org>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1578921090-9758-6-git-send-email-tamizhr@codeaurora.org>
User-Agent: NeoMutt/20170113 (1.7.2)
MIME-Version: 1.0
Received-SPF: None (protection.outlook.com: quantenna.com does not designate
 permitted sender hosts)
X-MS-Exchange-CrossTenant-Network-Message-Id: 633ac74e-5311-43d0-4716-08d798eda57d
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: a355dbce-62b4-4789-9446-c1d5582180ff
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: J8VPmWBYdxTVECQcBlS514eD5yF+7V4TV/eq+MPFHW1nrNOQR4SxiJK/bYBYf3KbrkEvVmLVJkl3e+sOcvHSlVlWvSrnMSSc40zaAQaJChzL18m0JD7N/dSnB3EmCHOntPTnBQdgIZvTvEKxlyQ+Bcb+EGPbajqOJbyvVEgVgOjvch7I502xOPvemV4ZXq774ISyEc+URnml+7niLKM7kBYlK4igAAtZi9u1tuX09+U=
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Jan 2020 12:32:06.3393
 (UTC)
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR05MB4751
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.138,18.0.572
 definitions=2020-01-14_03:2020-01-13,2020-01-14 signatures=0
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 priorityscore=1501 lowpriorityscore=0
 bulkscore=0 suspectscore=2 spamscore=0 phishscore=0 mlxlogscore=999
 impostorscore=0 malwarescore=0 mlxscore=0 clxscore=1015 adultscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-1910280000
 definitions=main-2001140105
Sender: linux-wireless-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-wireless.vger.kernel.org>
X-Mailing-List: linux-wireless@vger.kernel.org

> This patch adds support to configure per TID txrate configuration
> configuration through the NL80211_TID_CONFIG_ATTR_TX_RATE_TYPE
> and NL80211_TID_CONFIG_ATTR_TX_RATE
> attribute. TX bitrate mask values passed
> in NL80211_ATTR_TX_RATES attribute and NL80211_TID_CONFIG_ATTR_TX_RATES
> attribute will have types of the TX rate should be applied. This uses
> nl80211_parse_tx_bitrate_mask to validate and calculate the bitrate
> mask.
> 
> Signed-off-by: Tamizh chelvam <tamizhr@codeaurora.org>
> ---
>  include/net/cfg80211.h       |    5 +++
>  include/uapi/linux/nl80211.h |   24 +++++++++++++
>  net/wireless/nl80211.c       |   76 ++++++++++++++++++++++++++++++++----------
>  3 files changed, 88 insertions(+), 17 deletions(-)

...

> @@ -13936,6 +13947,37 @@ static int parse_tid_conf(struct cfg80211_registered_device *rdev,
>  			nla_get_u8(attrs[NL80211_TID_CONFIG_ATTR_RTSCTS_CTRL]);
>  	}
>  
> +	if (attrs[NL80211_TID_CONFIG_ATTR_TX_RATE_TYPE]) {
> +		int idx;
> +		enum nl80211_attrs attr;
> +
> +		err = nl80211_check_tid_config_support(rdev, extack, peer,
> +						       attrs, tid_conf,
> +						       TX_RATE);
> +		if (err)
> +			return err;
> +		idx = NL80211_TID_CONFIG_ATTR_TX_RATE_TYPE;
> +		tid_conf->txrate_type = nla_get_u8(attrs[idx]);
> +		if (tid_conf->txrate_type != NL80211_TX_RATE_AUTOMATIC) {
> +			tid_conf->mask =
> +				kzalloc(sizeof(struct cfg80211_bitrate_mask),
> +					GFP_KERNEL);
> +			if (!tid_conf->mask)
> +				return -ENOMEM;
> +
> +			attr =
> +			(enum nl80211_attrs)NL80211_TID_CONFIG_ATTR_TX_RATE;
> +			err = nl80211_parse_tx_bitrate_mask(info, attrs, attr,
> +							    tid_conf->mask);
> +			if (err) {
> +				kfree(tid_conf->mask);
> +				return err;
> +			}

IIUC we have to free all the allocated tid_conf->mask entries in the end of
nl80211_set_tid_config, right before tid_config is freed. Alternatively,
struct ieee80211_tid_cfg can be modified to keep cfg80211_bitrate_mask
value rather than pointer.

> +		} else {
> +			tid_conf->mask = NULL;
> +		}
> +	}
> +
>  	return 0;
>  }

Regards,
Sergey