Received-SPF: pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Message-ID: <b0978ab700c8b0551c0853763b57a79a1214f77b.camel@sipsolutions.net>
Subject: Re: [PATCH 2/2] nl80211: use src and dst addr attribute for control
 port tx/rx
From:   Johannes Berg <johannes@sipsolutions.net>
To:     Markus Theil <markus.theil@tu-ilmenau.de>
Cc:     linux-wireless@vger.kernel.org
Date:   Wed, 15 Jan 2020 12:30:17 +0100
In-Reply-To: <20200110145424.4518-2-markus.theil@tu-ilmenau.de>
References: <20200110145424.4518-1-markus.theil@tu-ilmenau.de>
         <20200110145424.4518-2-markus.theil@tu-ilmenau.de>
Content-Type: text/plain; charset="UTF-8"
User-Agent: Evolution 3.34.2 (3.34.2-1.fc31) 
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-wireless-owner@vger.kernel.org
Precedence: bulk

Hi Markus,

First, I think you should squash these two patches, there's no point in
adding unused attributes :-)

> The respective arguments are optional on tx and included on rx.
> Therefore unaware existing software is not affected.

This may be true, but doesn't *new* hostapd have to know that this is
supported, or otherwise fall back to sending the frames as data frames?

Seems to me a (driver) capability for this is needed.

johannes