Received-SPF: pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH v2 0/3] fix a STA PS bug and add PS support to
 mac80211_hwsim
To:     Johannes Berg <johannes@sipsolutions.net>
Cc:     linux-wireless <linux-wireless@vger.kernel.org>
References: <2b07e86b-9be7-4fc3-ae92-a4f831e585ef@email.android.com>
 <4c2d7cc81e83238512360903f38e12be16c16ed5.camel@sipsolutions.net>
From:   Thomas Pedersen <thomas@adapt-ip.com>
Message-ID: <bd9d68d2-114d-7e7a-000b-d2bf40658e74@adapt-ip.com>
Date:   Thu, 16 Jan 2020 09:54:03 -0800
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101
 Thunderbird/60.8.0
MIME-Version: 1.0
In-Reply-To: <4c2d7cc81e83238512360903f38e12be16c16ed5.camel@sipsolutions.net>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-wireless-owner@vger.kernel.org
Precedence: bulk

On 1/15/20 11:54 PM, Johannes Berg wrote:
> On Wed, 2020-01-15 at 23:53 -0800, thomas@adapt-ip.com wrote:
>>
>>> FWIW, I applied your patches yesterday. There was one issue remaining 
>>> uncovered by them, but it wasn't actually related to your patches, just 
>>> related to the test sending too many frames. I sent a workaround to the 
>>> hostap list and also the "mac80211: use more bits for ack_frame_id" to 
>>> the kernel to fix that. 
>>>
>>
>> But in the v3, no frames should actually be buffered unless power save
>> is explicitly enabled on the STA side. Or is this some rrm specific
>> behavior?
> 
> I didn't check whether or not powersave got enabled by default now, I
> sort of assumed it did? But that isn't really bad, almost all real
> devices will have it enabled by default too.

In v2 powersave was enabled by default, but that broke some test
assumptions (and p2p stuff I don't really understand), so v3 disables it
by default: https://lore.kernel.org/linux-wireless/20200114055940.18502-2-thomas@adapt-ip.com/T/#u

-- 
-- thomas