Received-SPF: pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII;
 format=flowed
Content-Transfer-Encoding: 7bit
Date:   Fri, 17 Jan 2020 17:04:01 +0530
From:   vjakkam@codeaurora.org
To:     Johannes Berg <johannes@sipsolutions.net>
Cc:     linux-wireless@vger.kernel.org
Subject: Re: [PATCH] cfg80211: Enhance the AKM advertizement to support per
 interface.
In-Reply-To: <6d2d94e01552f5713266add9e4909c85266e53ab.camel@sipsolutions.net>
References: <20191223185255.1009-1-vjakkam@codeaurora.org>
 <6d2d94e01552f5713266add9e4909c85266e53ab.camel@sipsolutions.net>
Message-ID: <69277bd9d6abac200c2dcd931521d084@codeaurora.org>
User-Agent: Roundcube Webmail/1.3.9
Sender: linux-wireless-owner@vger.kernel.org
Precedence: bulk

On 2020-01-02 19:11, Johannes Berg wrote:
> On Tue, 2019-12-24 at 00:22 +0530, Veerendranath Jakkam wrote:
>> 
>> @@ -2437,10 +2472,8 @@ static int nl80211_send_wiphy(struct 
>> cfg80211_registered_device *rdev,
>>  		state->split_start++;
>>  		break;
>>  	case 15:
>> -		if (rdev->wiphy.akm_suites &&
>> -		    nla_put(msg, NL80211_ATTR_AKM_SUITES,
>> -			    sizeof(u32) * rdev->wiphy.n_akm_suites,
>> -			    rdev->wiphy.akm_suites))
> 
> I don't think you should break this for all existing cases.
> 
> johannes

Thanks, I will correct in v2