Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp2033583ybl;
        Sun, 19 Jan 2020 17:20:13 -0800 (PST)
X-Google-Smtp-Source: APXvYqzQ0dqDt6vKDuJnvliTlI2TzBCCtKoDhDIWuVa5PZlsf5GaGs6eTgHxIcaQmjnZE/cwe8cb
X-Received: by 2002:aca:c509:: with SMTP id v9mr10843514oif.151.1579483213265;
        Sun, 19 Jan 2020 17:20:13 -0800 (PST)
ARC-Seal: i=1; a=rsa-sha256; t=1579483213; cv=none;
        d=google.com; s=arc-20160816;
        b=jKA0Sz8348LRIOjannZ2V1pKLy8tKBEw7Plbfo0TTRLsLOv+0b0ge5otboN+WZT6+s
         VR5u7QEsy0jR9o/9m9NyVWE/HEZZzbo42bPU+zeAFgwxrTt/PQRrnQoj0NJ+FX60kZFl
         cyJiqV2qXuiBb8CcZhig5wua83fCEcIpHRuchulfVMso+rn3b2bUOk7ZUasVyJhVIF2S
         JUcaF2vcR6/zlxjRtMfZlu7U4iIikzem3QpjzxoFNf94pZJ5SErIKZxFJOM+LhTQrzCx
         HXLDjcSbZdaiJEHL7W4Gmr4OeOfACHPyaPNE5GBCuv+t/soWXpKqpy+a4LQP1/jORoKG
         Tv3A==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=list-id:precedence:sender:cc:to:subject:message-id:date:from
         :in-reply-to:references:mime-version:dkim-signature;
        bh=StOpaJLAlWqkutfis3lnlKQAMkujEsqs3adqZGTuqtU=;
        b=gBTNeM2Etzfgwd5jARw30h85Xmzo6ANp7Ao7w6o94wKJz8mnQVgnra9h7vJG1aKzSi
         Vj0x+wlRaUVUOQOiLqyoYTmewOYcUmzqhQUwqveNuuQ/pW2WQGxxUKqFAS0xoSaxEF2a
         TYOtMgY21nG+Qed1tLB6ficAb+HAvbuwmxeZrNlzEx+WsDf3yluPOyuw27f7XWZJHvQR
         gUbUne/Jco2FzOet1GCj7A4b+eJ4yn2oFqASuSjVyVZJX/ZfhqLXEbZKNyrf3huNzoVP
         NfN/zQFTpy/MqvsDelSrBwRqziRZWzsQ/qLnGK3d0MiSQ8tdbm/3Nwh1pDz0OTUZW134
         Bs2Q==
ARC-Authentication-Results: i=1; mx.google.com;
       dkim=pass header.i=@gmail.com header.s=20161025 header.b=CHe1gicD;
       spf=pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org;
       dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com
Return-Path: <linux-wireless-owner@vger.kernel.org>
Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67])
        by mx.google.com with ESMTP id h5si16369708otn.280.2020.01.19.17.19.42;
        Sun, 19 Jan 2020 17:20:13 -0800 (PST)
Received-SPF: pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Authentication-Results: mx.google.com;
       dkim=pass header.i=@gmail.com header.s=20161025 header.b=CHe1gicD;
       spf=pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org;
       dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1728931AbgATBR0 (ORCPT <rfc822;firas.shaari@gmail.com>
        + 99 others); Sun, 19 Jan 2020 20:17:26 -0500
Received: from mail-ot1-f67.google.com ([209.85.210.67]:46386 "EHLO
        mail-ot1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1728909AbgATBR0 (ORCPT
        <rfc822;linux-wireless@vger.kernel.org>);
        Sun, 19 Jan 2020 20:17:26 -0500
Received: by mail-ot1-f67.google.com with SMTP id r9so27277041otp.13
        for <linux-wireless@vger.kernel.org>; Sun, 19 Jan 2020 17:17:25 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20161025;
        h=mime-version:references:in-reply-to:from:date:message-id:subject:to
         :cc;
        bh=StOpaJLAlWqkutfis3lnlKQAMkujEsqs3adqZGTuqtU=;
        b=CHe1gicDpMRIWgWVD6RYmR+YPM54YyVKfsgxYWheiieGlgDDQ2cYmP7KAxqnfNQE0d
         HUyn1H7gKxaC4c7yQKlRLL8UMPVEWtU3/rwsUm4gAwJaaeV7OI5S7bFDgjG2WJZ+apQN
         mpZkC9JI/2Vdr8NelpZFfnY1L1fe692Hyeoo0SJALfqv/n8dAspkUYs5ftByScKxd6Cp
         wlVkeM8E/PQqKSsak1d3DZjZ1gS+SfavJ6hfgDusNlc+6H1rxoOP9Rk4maKx+YrdcuMh
         /l3liS4aXttK1vDOsfqBT8ExLVpypfrs+ug0/figx6YrSASzx4EcpnGAumvrcjPS8o1V
         jfcg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20161025;
        h=x-gm-message-state:mime-version:references:in-reply-to:from:date
         :message-id:subject:to:cc;
        bh=StOpaJLAlWqkutfis3lnlKQAMkujEsqs3adqZGTuqtU=;
        b=Q05A2taXe0puhUbPrieUAQ/5xBpygRZt7CHfKY3yulKVByzQ8dep9Nwafg7vEBhRPv
         IqgyPSXovnFRRDJhdOp9U1Eyl1kXXJp7GCpubG4rb8ltzcHwgYHRc9AtShl0U/siL2TH
         0RRaeyyAlqXkrBXB4ickFbnA5ZT477kD5VV/nRhMqDWq40QqTMtfK+KqZ8IKDZ0p2ZpR
         9j7yB4Oq2Eeh0L7Yhfz020mK2i9Q30SKbK57J4JpKPJ7S+ZDZKEuR3lmfFrgmZ3jQq/5
         Jzre7Sq5QTY9aCBu6OeNU6tLh7uMjjwKMFWKPH6xLGKy3xevGXV6cE6TyzJc4UsFGMdl
         lchw==
X-Gm-Message-State: APjAAAXW57fb0K9lnI9iADqsTtwEjvB1XQvgwllx7YXrXFQn/MvZ40FP
        qc1MSZCuzvmAIXQjAgctJRJWoVySeGFbxd57kKQ=
X-Received: by 2002:a05:6830:1515:: with SMTP id k21mr13549208otp.177.1579483045276;
 Sun, 19 Jan 2020 17:17:25 -0800 (PST)
MIME-Version: 1.0
References: <20200117083605.392-1-wgong@codeaurora.org>
In-Reply-To: <20200117083605.392-1-wgong@codeaurora.org>
From:   Justin Capella <justincapella@gmail.com>
Date:   Sun, 19 Jan 2020 17:17:14 -0800
Message-ID: <CAMrEMU-57qrCP3Kh_cna-QNCBfGu6G3e0Y_0-wg6axq_EuoCcw@mail.gmail.com>
Subject: Re: [PATCH] ath10k: add retry mechanism for ath10k_start
To:     Wen Gong <wgong@codeaurora.org>
Cc:     ath10k <ath10k@lists.infradead.org>, linux-wireless@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Sender: linux-wireless-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-wireless.vger.kernel.org>
X-Mailing-List: linux-wireless@vger.kernel.org

Is the same address always used for "struct ath10k *ar = hw->priv" --
even when driver is stopped / bus errors are encountered? If not this
could potentially be use after free scenario?

Most code tries to protect the ->state with the config mutex, might
need to do that here too