Received-SPF: pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH v2] cfg80211: Enhance the AKM advertizement to support per
 interface.
To:     Veerendranath Jakkam <vjakkam@codeaurora.org>,
        johannes@sipsolutions.net
Cc:     linux-wireless@vger.kernel.org
References: <20191223185255.1009-1-vjakkam@codeaurora.org>
 <20200117113507.13503-1-vjakkam@codeaurora.org>
From:   Arend Van Spriel <arend.vanspriel@broadcom.com>
Message-ID: <a09e490e-a1e9-b4ec-afbf-438aef816435@broadcom.com>
Date:   Mon, 20 Jan 2020 09:57:33 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101
 Thunderbird/68.4.1
MIME-Version: 1.0
In-Reply-To: <20200117113507.13503-1-vjakkam@codeaurora.org>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-wireless-owner@vger.kernel.org
Precedence: bulk

On 1/17/2020 12:35 PM, Veerendranath Jakkam wrote:
> Commit ab4dfa20534e ("cfg80211: Allow drivers to advertise supported AKM
> suites") introduces the support to advertize supported AKMs to userspace.
> 
> This needs an enhancement to advertize the AKM support per interface type,
> specifically for the cfg80211-based drivers that implement SME and use
> different mechanisms to support the AKM's for each interface type (e.g.,
> the support for SAE, OWE AKM's take different paths for such drivers on
> STA/AP mode).
> 
> Add a new nl80211 attribute to provide supported AKMs per interface type
> to userspace.
> 
> This commit aims the same and enhances the earlier mechanism of advertizing
> the AKMs per wiphy. AKMs advertized in akm_suites are default capabilities
> if not advertized for a specific interface type in iftype_akm_suites.
> 
> Signed-off-by: Veerendranath Jakkam <vjakkam@codeaurora.org>
> ---
> Changelog:
> v1->v2:
>   -Keep advertizing support for AKM suites per wiphy
>   -AKM suites per interface overrides wiphy AKM suites for specific interface
>   -Rename new nl80211 attribute to NL80211_ATTR_IFTYPE_AKM_SUITES
> ---
>   include/net/cfg80211.h       | 22 +++++++++++++++++++-
>   include/uapi/linux/nl80211.h |  6 ++++++
>   net/wireless/nl80211.c       | 39 ++++++++++++++++++++++++++++++++++++
>   3 files changed, 66 insertions(+), 1 deletion(-)
> 
> diff --git a/include/net/cfg80211.h b/include/net/cfg80211.h
> index fa027d0d031b..10533dff2102 100644
> --- a/include/net/cfg80211.h
> +++ b/include/net/cfg80211.h
> @@ -4398,6 +4398,18 @@ struct cfg80211_pmsr_capabilities {
>   	} ftm;
>   };
>   
> +/**
> + * struct wiphy_iftype_akm_suites - supported akm suites per interface type
> + * @iftype: interface type
> + * @akm_suites: points to an array of supported akm suites
> + * @n_akm_suites: number of supported AKM suites
> + */
> +struct wiphy_iftype_akm_suites {
> +	enum nl80211_iftype iftype;

I can imagine certain iftypes could support same suites so maybe good to 
use bitmask of iftypes iso single iftype.

Regards,
Arend

> +	const u32 *akm_suites;
> +	int n_akm_suites;
> +};
> +