Received-SPF: pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Tue, 21 Jan 2020 10:17:25 +0300
From:   Sergey Matyukevich <sergey.matyukevich.os@quantenna.com>
To:     Tamizh Chelvam <tamizhr@codeaurora.org>
CC:     johannes@sipsolutions.net, linux-wireless@vger.kernel.org
Subject: Re: [PATCHv10 0/6] cfg80211/mac80211: Add support for TID specific
 configuration
Message-ID: <20200121071724.p6mbyiqjal3jjfin@bars>
Mail-Followup-To: Tamizh Chelvam <tamizhr@codeaurora.org>,
        johannes@sipsolutions.net, linux-wireless@vger.kernel.org
References: <1579506687-18296-1-git-send-email-tamizhr@codeaurora.org>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1579506687-18296-1-git-send-email-tamizhr@codeaurora.org>
User-Agent: NeoMutt/20170113 (1.7.2)
MIME-Version: 1.0
Received-SPF: None (protection.outlook.com: quantenna.com does not designate
 permitted sender hosts)
X-MS-Exchange-CrossTenant-Network-Message-Id: a1e56ab4-0035-42ce-53e1-08d79e41f9fa
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: a355dbce-62b4-4789-9446-c1d5582180ff
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: xjYXkjTaVDKwHbLvtNlgow9MgV6I4V32vhsTVLMkHdxuBojqeX9bAUGtHJ9HO/19Ol707LxarHotgqPUWn5kuXbEK0mHQ6Wb2KRizWEJigrgIJEodRZ72sPH8AWFtDOUwv6xOYnIuW4WE5TKls2UMiC1gCVU8SDsAUKJ2ch1ktYDRiRXbzNHrJFYXU/gQSFH8CNka+PymW0nNSf8rm/WCWgHPgd57BTbYB7pkJmRjik=
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Jan 2020 07:18:04.4054
 (UTC)
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR05MB5399
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.138,18.0.572
 definitions=2020-01-21_01:2020-01-20,2020-01-21 signatures=0
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 malwarescore=0 phishscore=0
 suspectscore=0 priorityscore=1501 mlxscore=0 bulkscore=0 clxscore=1015
 lowpriorityscore=0 adultscore=0 spamscore=0 mlxlogscore=999
 impostorscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-1910280000 definitions=main-2001210063
Sender: linux-wireless-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-wireless.vger.kernel.org>
X-Mailing-List: linux-wireless@vger.kernel.org

> Add infrastructure to support per TID configurations like noack policy,
> retry count, AMPDU control(disable/enable), RTSCTS control(enable/disable)
> and TX rate mask configurations.
> This will be useful for the driver which can supports data TID
> specific configuration rather than phy level configurations.
> Here NL80211_CMD_SET_TID_CONFIG added to support this operation by
> accepting TID configuration.
> This command can accept STA mac addreess to make the configuration
> station specific rather than applying to all the connected stations
> to the netdev.
> And this nested command configuration can accept multiple number of
> data TID specific configuration in a single command,
> enum ieee80211_tid_conf_mask used to notify the driver that which
> configuration got modified for the TID.
> 
> Tamizh chelvam (6):
>   nl80211: Add NL command to support TID speicific configurations
>   nl80211: Add support to configure TID specific retry configuration
>   nl80211: Add support to configure TID specific AMPDU configuration
>   nl80211: Add support to configure TID specific RTSCTS configuration
>   nl80211: Add support to configure TID specific txrate configuration
>   mac80211: Add api to support configuring TID specific configuration
> 
>  include/net/cfg80211.h       |   65 ++++++++++
>  include/net/mac80211.h       |   10 ++
>  include/uapi/linux/nl80211.h |  140 +++++++++++++++++++++
>  net/mac80211/cfg.c           |   56 +++++++++
>  net/mac80211/driver-ops.h    |   27 ++++
>  net/wireless/nl80211.c       |  287 +++++++++++++++++++++++++++++++++++++++---
>  net/wireless/rdev-ops.h      |   24 ++++
>  net/wireless/trace.h         |   37 ++++++
>  8 files changed, 629 insertions(+), 17 deletions(-)

Hello Tamizh,

Thanks for you fixes and patience! The last two versions look pretty
good to me.

Reviewed-by: Sergey Matyukevich <sergey.matyukevich.os@quantenna.com>

Regards,
Sergey