Received-SPF: pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII;
 format=flowed
Content-Transfer-Encoding: 7bit
Date:   Tue, 21 Jan 2020 13:11:02 +0530
From:   tamizhr@codeaurora.org
To:     Tamizh Chelvam <tamizhr@codeaurora.org>
Cc:     johannes@sipsolutions.net, linux-wireless@vger.kernel.org
Subject: Re: [PATCHv10 0/6] cfg80211/mac80211: Add support for TID specific
 configuration
In-Reply-To: <20200121071724.p6mbyiqjal3jjfin@bars>
References: <1579506687-18296-1-git-send-email-tamizhr@codeaurora.org>
 <20200121071724.p6mbyiqjal3jjfin@bars>
Message-ID: <528d2b83942394ae1aad08ffe7548a8a@codeaurora.org>
User-Agent: Roundcube Webmail/1.3.9
Sender: linux-wireless-owner@vger.kernel.org
Precedence: bulk

On 2020-01-21 12:47, Sergey Matyukevich wrote:
>> Add infrastructure to support per TID configurations like noack 
>> policy,
>> retry count, AMPDU control(disable/enable), RTSCTS 
>> control(enable/disable)
>> and TX rate mask configurations.
>> This will be useful for the driver which can supports data TID
>> specific configuration rather than phy level configurations.
>> Here NL80211_CMD_SET_TID_CONFIG added to support this operation by
>> accepting TID configuration.
>> This command can accept STA mac addreess to make the configuration
>> station specific rather than applying to all the connected stations
>> to the netdev.
>> And this nested command configuration can accept multiple number of
>> data TID specific configuration in a single command,
>> enum ieee80211_tid_conf_mask used to notify the driver that which
>> configuration got modified for the TID.
>> 
>> Tamizh chelvam (6):
>>   nl80211: Add NL command to support TID speicific configurations
>>   nl80211: Add support to configure TID specific retry configuration
>>   nl80211: Add support to configure TID specific AMPDU configuration
>>   nl80211: Add support to configure TID specific RTSCTS configuration
>>   nl80211: Add support to configure TID specific txrate configuration
>>   mac80211: Add api to support configuring TID specific configuration
>> 
>>  include/net/cfg80211.h       |   65 ++++++++++
>>  include/net/mac80211.h       |   10 ++
>>  include/uapi/linux/nl80211.h |  140 +++++++++++++++++++++
>>  net/mac80211/cfg.c           |   56 +++++++++
>>  net/mac80211/driver-ops.h    |   27 ++++
>>  net/wireless/nl80211.c       |  287 
>> +++++++++++++++++++++++++++++++++++++++---
>>  net/wireless/rdev-ops.h      |   24 ++++
>>  net/wireless/trace.h         |   37 ++++++
>>  8 files changed, 629 insertions(+), 17 deletions(-)
> 
> Hello Tamizh,
> 
> Thanks for you fixes and patience! The last two versions look pretty
> good to me.
> 
> Reviewed-by: Sergey Matyukevich <sergey.matyukevich.os@quantenna.com>
> 
Sergey,

Thanks for your continuous support in reviewing this patchset:)

Thanks,
Tamizh.