Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp5055175ybl; Wed, 22 Jan 2020 09:27:03 -0800 (PST) X-Google-Smtp-Source: APXvYqwvHfuyEZq3YI0C7799tsVyXbPJWYZ2+b0dupIt+xxQBD7pUYM0GmfV3ws7dGS0KTZwULvp X-Received: by 2002:a9d:6005:: with SMTP id h5mr8730768otj.153.1579714023150; Wed, 22 Jan 2020 09:27:03 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1579714023; cv=none; d=google.com; s=arc-20160816; b=gl/zIDJzYEJFSPWvViJwzykqTGqz+4TGotJ8ztTHPy1Y3QZGDlOVjZwFt3xJtnszg7 fkI+mk0tJYe8rH6YTSVXCq83vPgS7UiINZ+5NXkUCgjZe55WvRT8/OqGuM/wP6H1dWkT 70CBz2Y3HpJHPT2S8T4UrSApVb3JJKFmM5bra8dPPRRQQteoKdkErTJxzLG0Y9/i41uT 2OLIyep3IUNPR+dGYYZsomaQqZ+Jj75uAeiW56QgdoYw4xS9U179Obg7PGwlIaGXDyRw 2Q8BYK5Q0IbiLT7HHmeBDVUuGdjulpItLEUjsNLTYgj+BVapuN88LG/nJAOmGcJTRBL4 n+EA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:date:message-id:user-agent:cc:to :references:in-reply-to:from:subject:content-transfer-encoding :mime-version:dmarc-filter:dkim-signature; bh=JT8t4mKOX65qBwKaBugFTnYrziFh/b4z7AwIEFhR5+o=; b=WGQKnx/iGIsafW5hYE71m6OY0pLY/TvX8Mx+2ElVyWI5NamHZnFSNITRuHwRZTrIkQ cXc35kZIg5dYVoFJXwIq/dRHJr2tHrd3xEz3JHXYyQU1pW6nUhxO9a/4OLhovVva/MGl fbqmX0M8ZmxNFhTqpMVKQa8TTchCDvcrDbvbc5H9wJKDi3Q408CeV1E6ZzuMGsYaqmFu rUjENc589mhYgmYDM/WUerXk96mEcLhRLj84/BNFrkePG71uDamE2zQwvE2p/Qyvnzmi 6KaJfkPuL0pSj3stTpR7w1lF55JwH0Yh3ZkfaYaOKUUh8idhEHYhbLk3iKOQMIHDGCZk STVQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@mg.codeaurora.org header.s=smtp header.b=OuZZHL8O; spf=pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id v76si21250088oif.207.2020.01.22.09.26.39; Wed, 22 Jan 2020 09:27:03 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@mg.codeaurora.org header.s=smtp header.b=OuZZHL8O; spf=pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727141AbgAVR0W (ORCPT + 99 others); Wed, 22 Jan 2020 12:26:22 -0500 Received: from mail25.static.mailgun.info ([104.130.122.25]:28665 "EHLO mail25.static.mailgun.info" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726004AbgAVR0W (ORCPT ); Wed, 22 Jan 2020 12:26:22 -0500 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1579713981; h=Date: Message-Id: Cc: To: References: In-Reply-To: From: Subject: Content-Transfer-Encoding: MIME-Version: Content-Type: Sender; bh=JT8t4mKOX65qBwKaBugFTnYrziFh/b4z7AwIEFhR5+o=; b=OuZZHL8Oba9A0Co02wOADtdpqAjM2usUGDuzpUz5Xq/bhAcmrPxEW4o4Jwyg6GAwkadwQHVq 8sO5LXcwthrJueuNbU1Z5NviNn5TGdQEsPDZGYpD7tws9kl/URopfp2KCaxlAuiYy83x3O7L BPxQaaEC44RDluIcF3hz9KVrZMo= X-Mailgun-Sending-Ip: 104.130.122.25 X-Mailgun-Sid: WyI3YTAwOSIsICJsaW51eC13aXJlbGVzc0B2Z2VyLmtlcm5lbC5vcmciLCAiYmU5ZTRhIl0= Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by mxa.mailgun.org with ESMTP id 5e2885b2.7f52ca6ca1b8-smtp-out-n03; Wed, 22 Jan 2020 17:26:10 -0000 (UTC) Received: by smtp.codeaurora.org (Postfix, from userid 1001) id 217F2C433A2; Wed, 22 Jan 2020 17:26:09 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-caf-mail-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=0.5 required=2.0 tests=ALL_TRUSTED,MISSING_DATE, MISSING_MID,SPF_NONE autolearn=no autolearn_force=no version=3.4.0 Received: from potku.adurom.net (88-114-240-156.elisa-laajakaista.fi [88.114.240.156]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: kvalo) by smtp.codeaurora.org (Postfix) with ESMTPSA id C10CCC433CB; Wed, 22 Jan 2020 17:26:07 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org C10CCC433CB Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; spf=none smtp.mailfrom=kvalo@codeaurora.org Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [PATCH v4] iwlwifi: mvm: don't send the IWL_MVM_RXQ_NSSN_SYNC notif to Rx queues From: Kalle Valo In-Reply-To: <20191203080849.12013-1-emmanuel.grumbach@intel.com> References: <20191203080849.12013-1-emmanuel.grumbach@intel.com> To: Emmanuel Grumbach Cc: linux-wireless@vger.kernel.org, Emmanuel Grumbach , stable@vger.kernel.org User-Agent: pwcli/0.0.0-git (https://github.com/kvalo/pwcli/) Python/2.7.12 Message-Id: <20200122172609.217F2C433A2@smtp.codeaurora.org> Date: Wed, 22 Jan 2020 17:26:09 +0000 (UTC) Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Emmanuel Grumbach wrote: > The purpose of this was to keep all the queues updated with > the Rx sequence numbers because unlikely yet possible > situations where queues can't understand if a specific > packet needs to be dropped or not. > > Unfortunately, it was reported that this caused issues in > our DMA engine. We don't fully understand how this is related, > but this is being currently debugged. For now, just don't send > this notification to the Rx queues. This de-facto reverts my > commit 3c514bf831ac12356b695ff054bef641b9e99593: > > iwlwifi: mvm: add a loose synchronization of the NSSN across Rx queues > > This issue was reported here: > https://bugzilla.kernel.org/show_bug.cgi?id=204873 > https://bugzilla.kernel.org/show_bug.cgi?id=205001 > and others maybe. > > Fixes: 3c514bf831ac ("iwlwifi: mvm: add a loose synchronization of the NSSN across Rx queues") > CC: # 5.3+ > Signed-off-by: Emmanuel Grumbach Patch applied to wireless-drivers.git, thanks. d829229e35f3 iwlwifi: mvm: don't send the IWL_MVM_RXQ_NSSN_SYNC notif to Rx queues -- https://patchwork.kernel.org/patch/11270795/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches