Received-SPF: pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Message-ID: <5290eda7dee50997e7fa5bb5976256b024f7e94e.camel@sipsolutions.net>
Subject: Re: [PATCH v3] cfg80211: Enhance the AKM advertizement to support
 per interface.
From:   Johannes Berg <johannes@sipsolutions.net>
To:     Veerendranath Jakkam <vjakkam@codeaurora.org>
Cc:     linux-wireless@vger.kernel.org
Date:   Sun, 26 Jan 2020 18:32:45 +0100
In-Reply-To: <20200126112113.19542-1-vjakkam@codeaurora.org>
References: <20200117113507.13503-1-vjakkam@codeaurora.org>
         <20200126112113.19542-1-vjakkam@codeaurora.org>
Content-Type: text/plain; charset="UTF-8"
User-Agent: Evolution 3.34.2 (3.34.2-1.fc31) 
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-wireless-owner@vger.kernel.org
Precedence: bulk

On Sun, 2020-01-26 at 16:51 +0530, Veerendranath Jakkam wrote:
> 
> +
> +	nested = nla_nest_start(msg, NL80211_ATTR_IFTYPE_AKM_SUITES);
> +	if (!nested)
> +		return -ENOBUFS;
> +
> +	for (i = 0; i < rdev->wiphy.num_iftype_akm_suites; i++) {
> +		nested_akms = nla_nest_start(msg, i + 1);
> +		if (!nested_akms)
> +			return -ENOBUFS;
> +
> +		iftype_akms = &rdev->wiphy.iftype_akm_suites[i];
> +
> +		if (nl80211_put_iftypes(msg, NL80211_ATTR_SUPPORTED_IFTYPES,
> +					iftype_akms->iftypes_mask))
> +			return -ENOBUFS;
> +
> +		if (nla_put(msg, NL80211_ATTR_AKM_SUITES,

Using the top-level attributes inside the nesting makes things
unnecessarily difficult to understand and take far more memory to parse,
IMHO it'd be better to define a new set of inner attributes
NL80211_IFTYPE_AKM_ATTR_IFTYPES, ..._SUITES or so.

johannes