Received-SPF: pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII;
 format=flowed
Content-Transfer-Encoding: 7bit
Date:   Mon, 27 Jan 2020 01:53:21 +0530
From:   vjakkam@codeaurora.org
To:     Johannes Berg <johannes@sipsolutions.net>
Cc:     linux-wireless@vger.kernel.org
Subject: Re: [PATCH v3] cfg80211: Enhance the AKM advertizement to support per
 interface.
In-Reply-To: <5290eda7dee50997e7fa5bb5976256b024f7e94e.camel@sipsolutions.net>
References: <20200117113507.13503-1-vjakkam@codeaurora.org>
 <20200126112113.19542-1-vjakkam@codeaurora.org>
 <5290eda7dee50997e7fa5bb5976256b024f7e94e.camel@sipsolutions.net>
Message-ID: <89bad215ed8dbf917a9583c572298c7d@codeaurora.org>
User-Agent: Roundcube Webmail/1.3.9
Sender: linux-wireless-owner@vger.kernel.org
Precedence: bulk

On 2020-01-26 23:02, Johannes Berg wrote:
> On Sun, 2020-01-26 at 16:51 +0530, Veerendranath Jakkam wrote:
>> 
>> +
>> +	nested = nla_nest_start(msg, NL80211_ATTR_IFTYPE_AKM_SUITES);
>> +	if (!nested)
>> +		return -ENOBUFS;
>> +
>> +	for (i = 0; i < rdev->wiphy.num_iftype_akm_suites; i++) {
>> +		nested_akms = nla_nest_start(msg, i + 1);
>> +		if (!nested_akms)
>> +			return -ENOBUFS;
>> +
>> +		iftype_akms = &rdev->wiphy.iftype_akm_suites[i];
>> +
>> +		if (nl80211_put_iftypes(msg, NL80211_ATTR_SUPPORTED_IFTYPES,
>> +					iftype_akms->iftypes_mask))
>> +			return -ENOBUFS;
>> +
>> +		if (nla_put(msg, NL80211_ATTR_AKM_SUITES,
> 
> Using the top-level attributes inside the nesting makes things
> unnecessarily difficult to understand and take far more memory to 
> parse,
> IMHO it'd be better to define a new set of inner attributes
> NL80211_IFTYPE_AKM_ATTR_IFTYPES, ..._SUITES or so.
> 
> johannes

Thanks, I will correct this in v4 as per suggestion

veeru