Received-SPF: pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Message-ID: <0a39afdd47460597c51a0a6ea9871f78d9ea5854.camel@sipsolutions.net>
Subject: Re: mac80211: background scan issue
From:   Johannes Berg <johannes@sipsolutions.net>
To:     Cedric VONCKEN <cedric.voncken@acksys.fr>,
        "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
Date:   Mon, 03 Feb 2020 23:29:52 +0100
In-Reply-To: <DB8PR01MB5529FBFD07C989F0E934CDD990000@DB8PR01MB5529.eurprd01.prod.exchangelabs.com> (sfid-20200203_164721_336174_40CD3BE8)
References: <DB8PR01MB5529FBFD07C989F0E934CDD990000@DB8PR01MB5529.eurprd01.prod.exchangelabs.com>
         (sfid-20200203_164721_336174_40CD3BE8)
Content-Type: text/plain; charset="UTF-8"
User-Agent: Evolution 3.34.2 (3.34.2-1.fc31) 
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-wireless-owner@vger.kernel.org
Precedence: bulk

Hi,

	
> @@ -297,7 +297,8 @@ ieee80211_tx_h_check_assoc(struct ieee80
>        if (unlikely(test_bit(SCAN_SW_SCANNING, &tx->local->scanning)) &&
>            test_bit(SDATA_STATE_OFFCHANNEL, &tx->sdata->state) &&
>            !ieee80211_is_probe_req(hdr->frame_control) &&
> -          !ieee80211_is_nullfunc(hdr->frame_control))
> +          !ieee80211_is_nullfunc(hdr->frame_control) &&
> +              !ieee80211_is_qos_nullfunc(hdr->frame_control))
>                /*
>                 * When software scanning only nullfunc frames (to notify
>                 * the sleep state to the AP) and probe requests (for the

yeah, Thomas also found it, we now have this in the tree:

        if (unlikely(test_bit(SCAN_SW_SCANNING, &tx->local->scanning)) &&
            test_bit(SDATA_STATE_OFFCHANNEL, &tx->sdata->state) &&
            !ieee80211_is_probe_req(hdr->frame_control) &&
            !ieee80211_is_any_nullfunc(hdr->frame_control))

johannes