Received-SPF: pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Fri, 7 Feb 2020 18:22:18 +0100
From:   Lorenzo Bianconi <lorenzo.bianconi@redhat.com>
To:     Felix Fietkau <nbd@nbd.name>
Cc:     Lorenzo Bianconi <lorenzo@kernel.org>,
        linux-wireless@vger.kernel.org
Subject: Re: [PATCH 2/3] mt76: generalize mt76_mcu_rx_event routine
Message-ID: <20200207172218.GA2538@localhost.localdomain>
References: <cover.1580945999.git.lorenzo@kernel.org>
 <0b2e476900157cd99417328e661e71a6ffedcb6a.1580945999.git.lorenzo@kernel.org>
 <9206f86a-8bd5-1f43-482d-8027e1a60d42@nbd.name>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="6TrnltStXW4iwmi0"
Content-Disposition: inline
In-Reply-To: <9206f86a-8bd5-1f43-482d-8027e1a60d42@nbd.name>
Sender: linux-wireless-owner@vger.kernel.org
Precedence: bulk


--6TrnltStXW4iwmi0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Feb 07, Felix Fietkau wrote:
> On 2020-02-06 00:53, Lorenzo Bianconi wrote:
> > Rely on mt76_mcu in mt76_mcu_rx_event signature in order to reuse
> > it in usb code
> >=20
> > Signed-off-by: Lorenzo Bianconi <lorenzo@kernel.org>
> > ---
> >  drivers/net/wireless/mediatek/mt76/mcu.c          | 8 +++++---
> >  drivers/net/wireless/mediatek/mt76/mt76.h         | 2 +-
> >  drivers/net/wireless/mediatek/mt76/mt7603/dma.c   | 4 ++--
> >  drivers/net/wireless/mediatek/mt76/mt7615/mcu.c   | 2 +-
> >  drivers/net/wireless/mediatek/mt76/mt76x02_txrx.c | 3 +--
> >  5 files changed, 10 insertions(+), 9 deletions(-)
> >=20
> > diff --git a/drivers/net/wireless/mediatek/mt76/mcu.c b/drivers/net/wir=
eless/mediatek/mt76/mcu.c
> > index b0fb0830c9e1..a2936f8de915 100644
> > --- a/drivers/net/wireless/mediatek/mt76/mcu.c
> > +++ b/drivers/net/wireless/mediatek/mt76/mcu.c
> > @@ -42,9 +42,11 @@ struct sk_buff *mt76_mcu_get_response(struct mt76_de=
v *dev,
> >  }
> >  EXPORT_SYMBOL_GPL(mt76_mcu_get_response);
> > =20
> > -void mt76_mcu_rx_event(struct mt76_dev *dev, struct sk_buff *skb)
> > +void mt76_mcu_rx_event(void *data, struct sk_buff *skb)
> Why the void* pointer if we have the mcu struct in a common place in
> struct mt76_dev anyway?

ack, I will fix it in v2

Regards,
Lorenzo

>=20
> - Felix
>=20

--6TrnltStXW4iwmi0
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYIAB0WIQTquNwa3Txd3rGGn7Y6cBh0uS2trAUCXj2cxwAKCRA6cBh0uS2t
rK6WAP0cZtEBPWs3aE8QTcFqTouZh98U2CEsPhCam2OTGhH8IwEAonWeJZ7FArgG
RtjtPMGdbMrulxhH8hqso2TZcu36YQQ=
=/K1J
-----END PGP SIGNATURE-----

--6TrnltStXW4iwmi0--