Received-SPF: pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Fri, 7 Feb 2020 18:29:24 +0100
From:   Lorenzo Bianconi <lorenzo.bianconi@redhat.com>
To:     Felix Fietkau <nbd@nbd.name>
Cc:     Lorenzo Bianconi <lorenzo@kernel.org>,
        linux-wireless@vger.kernel.org
Subject: Re: [PATCH 1/3] mt76: reuse mt76_mcu in mt76u_mcu
Message-ID: <20200207172924.GB2538@localhost.localdomain>
References: <cover.1580945999.git.lorenzo@kernel.org>
 <9edce905c69623f50f64b0904e0657d1345b0ffe.1580945999.git.lorenzo@kernel.org>
 <3b5b64dd-8939-b730-5b2c-f720a8e1d001@nbd.name>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="wzJLGUyc3ArbnUjN"
Content-Disposition: inline
In-Reply-To: <3b5b64dd-8939-b730-5b2c-f720a8e1d001@nbd.name>
Sender: linux-wireless-owner@vger.kernel.org
Precedence: bulk


--wzJLGUyc3ArbnUjN
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Feb 07, Felix Fietkau wrote:
> On 2020-02-06 00:53, Lorenzo Bianconi wrote:
> > Introduce mt76_mcu data structure to contain common fields between
> > mt76u_mcu and mt76e_mcu.
> > Move mt76u_mcu at the beginning of mt76_usb in order to rely on mt76_mcu
> > to access mt76u_mcu common fields
> Why not move it to struct mt76_dev directly and out of the union?
> I think that would be cleaner, and you can also initialize its fields in
> mt76_alloc_device().

ack and I can maintain the usb specific fields (e.g mt76_reg_pair or burst)=
 in
mt76u_mcu. I will fix it in v2

Regards,
Lorenzo

>=20
> - Felix
>=20

--wzJLGUyc3ArbnUjN
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYIAB0WIQTquNwa3Txd3rGGn7Y6cBh0uS2trAUCXj2ecQAKCRA6cBh0uS2t
rMsZAQCzIPAfCVDiCkk4hSKdvPUKF4uQBFb7fTQFsdoR0UQtywEAwd5yxQ7LO6n8
EkwrTFzWJVKIE4j0AhmmaKc9sGgvuwM=
=AyaW
-----END PGP SIGNATURE-----

--wzJLGUyc3ArbnUjN--