Received-SPF: pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Message-ID: <3c6bdd85a2d476d9ca7268803c03d0ae417a7560.camel@sipsolutions.net>
Subject: Re: [PATCH v2] mac80211: Fix setting txpower to zero.
From:   Johannes Berg <johannes@sipsolutions.net>
To:     Ben Greear <greearb@candelatech.com>,
        linux-wireless@vger.kernel.org
Date:   Fri, 07 Feb 2020 20:19:26 +0100
In-Reply-To: <5E3DA498.20505@candelatech.com>
References: <20191217183057.24586-1-greearb@candelatech.com>
                 (sfid-20191217_193103_026347_235EB2CE) <27b64bd26e7d8c13d22a3a9b950eb3db16b630a2.camel@sipsolutions.net>
         <5E3DA498.20505@candelatech.com>
Content-Type: text/plain; charset="UTF-8"
User-Agent: Evolution 3.34.2 (3.34.2-1.fc31) 
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-wireless-owner@vger.kernel.org
Precedence: bulk

On Fri, 2020-02-07 at 09:55 -0800, Ben Greear wrote:
> On 02/07/2020 04:03 AM, Johannes Berg wrote:
> > On Tue, 2019-12-17 at 10:30 -0800, greearb@candelatech.com wrote:
> > >   drivers/net/wireless/ath/ath10k/mac.c | 3 ++-
> > >   drivers/net/wireless/ath/ath9k/main.c | 3 +++
> > >   drivers/net/wireless/ath/ath9k/xmit.c | 7 +++++--
> > 
> > All these driver changes worry me a bit - wouldn't that affect other
> > drivers as well?

> The goal was to NOT adversely affect the drivers when the default (not-set)
> value changed.

Right.

> I changed the name of the variable and then touched every driver that used it
> as a way of making sure that I found everything in the tree.
> 
> Hopefully that found everything...  I did not specifically test ath9k, only ath10k
> driver with this change.
> 
> (I then changed the variable name back before submitting the patch).

OK, great, thanks :)

johannes