Received-SPF: pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Message-ID: <5E3DC72E.1050403@candelatech.com>
Date:   Fri, 07 Feb 2020 12:23:10 -0800
From:   Ben Greear <greearb@candelatech.com>
Organization: Candela Technologies
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.3.0
MIME-Version: 1.0
To:     Johannes Berg <johannes@sipsolutions.net>,
        linux-wireless@vger.kernel.org
Subject: Re: [PATCH v2] mac80211: Fix setting txpower to zero.
References: <20191217183057.24586-1-greearb@candelatech.com>                 (sfid-20191217_193103_026347_235EB2CE) <27b64bd26e7d8c13d22a3a9b950eb3db16b630a2.camel@sipsolutions.net>         <5E3DA498.20505@candelatech.com> <3c6bdd85a2d476d9ca7268803c03d0ae417a7560.camel@sipsolutions.net>
In-Reply-To: <3c6bdd85a2d476d9ca7268803c03d0ae417a7560.camel@sipsolutions.net>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-wireless-owner@vger.kernel.org
Precedence: bulk

On 02/07/2020 11:19 AM, Johannes Berg wrote:
> On Fri, 2020-02-07 at 09:55 -0800, Ben Greear wrote:
>> On 02/07/2020 04:03 AM, Johannes Berg wrote:
>>> On Tue, 2019-12-17 at 10:30 -0800, greearb@candelatech.com wrote:
>>>>    drivers/net/wireless/ath/ath10k/mac.c | 3 ++-
>>>>    drivers/net/wireless/ath/ath9k/main.c | 3 +++
>>>>    drivers/net/wireless/ath/ath9k/xmit.c | 7 +++++--
>>>
>>> All these driver changes worry me a bit - wouldn't that affect other
>>> drivers as well?
>
>> The goal was to NOT adversely affect the drivers when the default (not-set)
>> value changed.
>
> Right.
>
>> I changed the name of the variable and then touched every driver that used it
>> as a way of making sure that I found everything in the tree.
>>
>> Hopefully that found everything...  I did not specifically test ath9k, only ath10k
>> driver with this change.
>>
>> (I then changed the variable name back before submitting the patch).
>
> OK, great, thanks :)

Come to think of it, I did not do an 'all mod config' build, so possibly I missed some
things.  I think my kernel compiles most of the drivers though.

Thanks,
Ben


-- 
Ben Greear <greearb@candelatech.com>
Candela Technologies Inc  http://www.candelatech.com