Received: by 2002:a25:1506:0:0:0:0:0 with SMTP id 6csp3542772ybv; Mon, 10 Feb 2020 01:48:30 -0800 (PST) X-Google-Smtp-Source: APXvYqwI+6nCobfHMICim+L6/ownlEu3eUiJ0151JW1z0R8YkpuBZtRX9Fb4SSRPw2xEkXy/I2ms X-Received: by 2002:a05:6830:15a:: with SMTP id j26mr400472otp.137.1581328110016; Mon, 10 Feb 2020 01:48:30 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1581328110; cv=none; d=google.com; s=arc-20160816; b=dhbjNqkQVeyeWJxRo07NiGECP+Tj7EPyJusomDs7LWYkrECQXbdU25hcFksb+UjL1g 7eOE/pSkhSkfx1CjK1K9k4uiq0XRL4BtzmLhvJ7A0F2AlWIfP8mYVaTeI6Nt3IRY6wI9 q0F60K9iJo4RRfha1eygr72/9SSZbSm0q5Y48v1xP55L1+gZCEAB4YPjajPSCISJX5pP b64Iis8KU5rPXCnRYXlmQX4vBpLHFG9NP//9Y3n6JZO497O2RCF3E7rwfibFls7Mv0A4 t2A+EcaoVft90bEgy8o6h4eE0W+RAAJaH3RghfMrYBsDg7LJHkfwOtib1XPS3mKe+S7Z mkDw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-language :content-transfer-encoding:in-reply-to:mime-version:user-agent:date :message-id:autocrypt:from:references:cc:to:subject; bh=eB+ABIIfdThqKa09RXzXRtKVCT9aBca751i0pHDHqDI=; b=O2ZoBLfb1sWfu7f99CwKeu/5MQONC3YhQ4Y+fVGNoq3b8eCRfjm4m0dp61Od6TIhA+ XEodUfurv+R+Srj8VGBVlFvi42m3hcPJbu6nkZTegVJPWPycM7cLOEFe6dfifiaq7K8C eXf1AlouDEJFSI9pHLk+lQpX08Ijt7hGeqptmOQ80C7cyCQcU9PXNp5hXBG6s8oQ0fbZ nQbFVN+8VKeaNZWbp7up7hrfS96wnsKF2/4tQEaTbvqG2NdM7uURv146zhFJoKk5ASNG gIzfj3umD3Hed/JY6EvmhIgeN2JwB32ix2KX3bFQ/wuyc/SpQg+twBXwVYwITUvZ+nvl Xncg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 24si7854742oip.248.2020.02.10.01.48.19; Mon, 10 Feb 2020 01:48:30 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727435AbgBJJsK (ORCPT + 99 others); Mon, 10 Feb 2020 04:48:10 -0500 Received: from smail.rz.tu-ilmenau.de ([141.24.186.67]:52025 "EHLO smail.rz.tu-ilmenau.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727029AbgBJJsK (ORCPT ); Mon, 10 Feb 2020 04:48:10 -0500 Received: from [192.168.178.26] (unknown [84.174.247.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smail.rz.tu-ilmenau.de (Postfix) with ESMTPSA id 3E1AE580073; Mon, 10 Feb 2020 10:48:08 +0100 (CET) Subject: Re: [PATCH 1/2] iw: scan: fix endless loop in print_measurement_pilot_tx To: johannes@sipsolutions.net Cc: linux-wireless@vger.kernel.org References: <20200210094619.14416-1-markus.theil@tu-ilmenau.de> From: Markus Theil Autocrypt: addr=markus.theil@tu-ilmenau.de; keydata= mQINBFcopAYBEADBcwd5L8+T0zgqq4kYY4nQt6CYh5sOalHdI3zNE6fWbRbzQwViIlC9Q0q/ ys+nMmQajMWHalsgcdeVSQ2GJ/06qhtogCpmL3d2/GdlvVROh33zeqwqevscKvPH5i7oiBhh dMs8/5g89q4aTYtyaausy8qQbv3Q8BCVkwFW2pEcqfxNKgWi/8nM2A3powNA9gzCR2rmoGyd nvQNkk0MCwT8JSGnUkiEYEkWF4aIr3XToavpn+OMIIIizcDzRwU5NBmC3Q07PQTn8Srr+rJQ DF65vgaoI8G7wlNLQYavL1uFX1LVMP1jVr6GMOczeURqiF/QSuHCdyT3R8P3Qknc74tGT2Ow EbxllMnk1gvSfGQq47EYIvuXFyMUWOjjtgP+NxryXVAvQBmuqWWjRjfqMSx9URhvB/ZMQLbZ LUPNW0Whl/vOQdxVbEMQOSKhKYoWKeCDe7567sEi02bMScvr6ybKBvRMs71hT1T+HFcBE/IJ g3ZX+6qRzs+XKLTFGipRbRiLYKKNR+UM/sNc/w+3BTowB9g/cQukrITvb792T4/IPBJzpEry 9eZFhFTlIqggy/fGrpZkEpEsOyOWYlRyseETvNdrdeVG7dRGPj68jKUWTVcAaAAiu8WhgnvG 4tvpaORUhjdg4DfkbE9b9lvYkeesFsE0bUAd5z2DeVbtR0QBUwARAQABtClNYXJrdXMgVGhl aWwgPG1hcmt1cy50aGVpbEB0dS1pbG1lbmF1LmRlPokCPQQTAQoAJwUCVyikBgIbAwUJB4Yf gAULCQgHAwUVCgkICwUWAgMBAAIeAQIXgAAKCRBt3CLaT/oEE5bzD/94Ezfl7mm57PXniW3m yIcjofJXw7YCJOprUon36W2Na2xrH3j8QH/sqkfTyCoj1LWxxDGQs+CQGkZ47cX+H1KqKKSS iGoNRV/cvoozWe7cn9bAvR3JkqLxjIi0vp68rs/f6ZI49N7zuZAsSBrXN2/2xIgH+mRoAPyw mgzaIXZL87vajXol4TlbMaC7blRs6Q4kzOP7ZjvfM/yxwUsifQltNY4wAEWKXLk67ij9akGO FG+y3sHF1HYH3w0sB+mIIN3x4BjYqXSH3XDx4xvCQXWkHmFl1RoQbJDvMjxP5/HXLR3omPjF ZpV657Grh/PgonwZ/U6sigaA11pjcPfkYNYkcGyb0OMqSKb3Ke52/bhxv4pPWrKRS7btMhj7 4zuMDk9V+De3YFXvKGllXBMAA6J8TlY71rlcOWKyBQNLLkUZ7/uAA949GTNzM0fPTRqry5qn WCR/ekzm3VyFgjWSun39L1W13bJW8aUu8k5x2KWq4YrdB0TOYZpKSAconOHVxhkEMxLwRUfZ B9kEPqlfQY5YYE6ZoZQF38Kvx3VFuAnhf+82PjMMrkQ3g07D3xJlq7xWdq1jrwG1QxmVFS64 g+oWM9IIFisvVspNrJAEgSGmYgTw+VT3PDP3Gj8sqD32mWb18bVE9I5FyagOewKdLpqcljIi Bz8WAuz+RbwX4i/mMrkCDQRXKKQGARAAzTGnHyUtTBcGHMKArcGiVnCB6knTFgU7I1gsoBrc J1bo0JRJj1lduYkdm12kC49c4dZtv1CciQIN9UEpalZsB2TXaC/xaDJ2IsZuHLOOaqSSwVg/ Bs41vMeFYmmwRRN1y6MQRCBobCC6KNuCpgtEmS/v4hurISt+MoPIppjK6E7tJQ0lgtfRHq/M HW+Wabw5Nq3OFSaLYC3nRJkoB1Vej8XGO8X6URWnZmL3xcnkIkoH13y2WTO0lJz9tF47t5U2 +xWrFMR+a6ow/QPL4Wi53IqhXDqa6OUzDAUuplZOm71VhwsEkk6u0YjzNRbgAYMBh7iye2j/ 4Lf2+YUB8+uKimpsEwW0nR85sKCQm102Zb9+1bYXPuIIP9HbVNy77X4aM9V0W48zBTqWZzh8 2i0oq8z1xN3qeuZbAXnzelKZvE1wM9cLQ3YHA629J2OGe3dkv2+untuyj6KMCEU3+vp6j7TX hKf+jy3PIrQcQmzMTs7xnkEm5LvbAtaZLrg4OGYjSpvH4bKsLA3sNGt5Xqsuqh5dsO7ccX1G nfY7Ug8UyNT5/0gZVkOileTQl0KtgwO9VBXAdrmMPHFldRn3dGNiGlCbxnsaNQDfQwTFmDu0 1TjzwC4byWLQT+C7yCTk8h9q0NwmCJ5yG7Fe7VUUpA+ZVLyMSt+tSpH8v3n+3I2AKoMAEQEA AYkCJQQYAQoADwUCVyikBgIbDAUJB4YfgAAKCRBt3CLaT/oEE7lZEACgrOxRaCQ7D5Rc4BOA N4VDIQqVch8X3pBE/k/v3UopkgmYnP4RlhegWr4wp2E6Vuyt8nwnZs3WhxQENfMjd5rV3WhG k5ib+pmLvtAht5j8jfP5+UKUTvX1a6oMi98PT8PuQ70oKM7T/KN+RpXIHoz/2Dgde1RQpwKC XWtkU9tBF87fE8FfwuqS6myOfd8zc6fOVV/fxmTXVC8qA7tB+0tOSDHB80GRYwnlumChOtOB Np8ABFWryE2e6mZZnp9Tpd1A74B45z6l445f5BixGLExAOoTJNA2k0JWx79/2Yi+pwTnQMzW QBLa48MnL3DUlVlahz1FZfGbA2U5NARS8iRdUhCaHL0Lph8HxWJwYA5w2afyCCwRD7xFo44V jsCNbqtZ6TrFARJdrbeWQl3RZ4Y+uuvN9mgvttVenAbx5d68IariYtXashucQeIMoqIloHTN sJDaupNm6+A9T3Re5yXmZsrWSxEEEGv1Bh+5DH6vauP0Ng0ebZ4c6jXfgLpPnAUWlV0rnmrJ q9141nbyLRYAhUXxiqajb+Zocp2Am4BF19rBUa1C78ooye9XShhuQvDTB6tZuiYWc24tiyqb IjR1hmG/zg8APhURAv/zUubaf4IA7v5YHVQqAbpUfb6ePlPVJBtVw2CwXFrGwnqDFh82La8D sGZPq8zmOtvOyZtafA== Message-ID: Date: Mon, 10 Feb 2020 10:48:07 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.4.2 MIME-Version: 1.0 In-Reply-To: <20200210094619.14416-1-markus.theil@tu-ilmenau.de> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Content-Language: en-US Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org On 2/10/20 10:46 AM, Markus Theil wrote: I forgot my signed-off-by, feel free to add. > --- > scan.c | 16 ++++++++++------ > 1 file changed, 10 insertions(+), 6 deletions(-) > > diff --git a/scan.c b/scan.c > index 98c5c10..a5beb0e 100644 > --- a/scan.c > +++ b/scan.c > @@ -1548,6 +1548,7 @@ static void print_measurement_pilot_tx(const uint8_t type, uint8_t len, > ++p; > uint8_t len = *p; > ++p; > + const uint8_t *end = p + len; > > len_remaining -= 2; > > @@ -1557,18 +1558,21 @@ static void print_measurement_pilot_tx(const uint8_t type, uint8_t len, > return; > } > > - printf("\t\t * vendor specific: OUI %.2x:%.2x:%.2x, data:", > - p[0], p[1], p[2]); > - len_remaining -= 3; > - > - if (len > len_remaining) { > + if (len < 3 || len > len_remaining) { > printf(" \n"); > return; > } > > - while (p < p + len) > + printf("\t\t * vendor specific: OUI %.2x:%.2x:%.2x, data:", > + p[0], p[1], p[2]); > + /* add only two here and use ++p in while loop */ > + p += 2; > + > + while (++p < end) > printf(" %.2x", *p); > printf("\n"); > + > + len_remaining -= len; > } > } >