Received: by 2002:a25:1506:0:0:0:0:0 with SMTP id 6csp3586263ybv; Mon, 10 Feb 2020 02:44:47 -0800 (PST) X-Google-Smtp-Source: APXvYqzQyE5wmEZHDhqVS3v04JF20hk0UzlqdAWiclr2hJSLVvEdfQ5/U6S9m1oVL+Jy01SQkt7u X-Received: by 2002:a9d:6a48:: with SMTP id h8mr583791otn.264.1581331487821; Mon, 10 Feb 2020 02:44:47 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1581331487; cv=none; d=google.com; s=arc-20160816; b=Xl5uky5ZRHBPXv4KFDiLfQHfHlditw1H+3FHQkUHKXLHcnWMPfkYlgbR2b9Nj99Adv 0DhQTO2sJWetV4rl5C3Ce9GGew0DiD5fzSLW2ak0QDqfMSCXA//fk2F5c1h8HRNf3EM0 wF/478DbmzzmsZ90JW0XF8op5AA1IDOPtGKI/TGj/xgsBbin+I2zaTwK6yiIMqBJZG8Z D402gAvITjBmGZURNfP/x7wz5jX7QrrynAGf3286v/MKCvhC4OzqbhVTJuAJqxUretus kMfJjkiOJFR6GGuiIaeDGKeR3cC/vcRBa1xYquwmseMaAEWGE5HEzPWEzzBV8FpvafVS 1a2Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=VCrDnoOfx3V9LMACDW7SRMLEw5K3yqDeE7pyXhIu96Y=; b=SWtI/DIOs6N5VR7tcN56FLB3gyILTODkBXDeC5+2/TCPDOWjhfO29DTscpviK04rPO rGk+CbwAJ1SU2302oioa8jdTv9huOo4R1oBuAIMd+rzvV5osVMNrtJv1b8AJeHlOg9z+ GueCvb42qSxG9Nsf+YckOSbF97iT10R1F0rfXYUpnHB5nQF9j12PsaY4GVlPWgJ9IkN0 GHxEPsHE2H4Bk2McjlZ/iDJoKoG0bkDXnfkalDFDAjBTHCgYxjHJ2HeREx/8P+wCo7LN 11rQPcCb5fqzLFhvWtw+gjnkqzQdi48GFjpF19hmdAHBD9/iwB6122dz8j4DzKzVBtya 3AJg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id r10si5803otk.83.2020.02.10.02.44.35; Mon, 10 Feb 2020 02:44:47 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727003AbgBJKof (ORCPT + 99 others); Mon, 10 Feb 2020 05:44:35 -0500 Received: from smail.rz.tu-ilmenau.de ([141.24.186.67]:52399 "EHLO smail.rz.tu-ilmenau.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726792AbgBJKof (ORCPT ); Mon, 10 Feb 2020 05:44:35 -0500 Received: from isengard.fritz.box (unknown [84.174.247.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smail.rz.tu-ilmenau.de (Postfix) with ESMTPSA id 6FA58580074; Mon, 10 Feb 2020 11:44:33 +0100 (CET) From: Markus Theil To: johannes@sipsolutions.net Cc: linux-wireless@vger.kernel.org, Markus Theil Subject: [PATCH v2] iw: scan: fix endless loop in print_measurement_pilot_tx Date: Mon, 10 Feb 2020 11:44:20 +0100 Message-Id: <20200210104420.1647-1-markus.theil@tu-ilmenau.de> X-Mailer: git-send-email 2.25.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Signed-off-by: Markus Theil --- scan.c | 16 ++++++++++------ 1 file changed, 10 insertions(+), 6 deletions(-) diff --git a/scan.c b/scan.c index eaa3bef..dbfe44c 100644 --- a/scan.c +++ b/scan.c @@ -1548,6 +1548,7 @@ static void print_measurement_pilot_tx(const uint8_t type, uint8_t len, ++p; uint8_t len = *p; ++p; + const uint8_t *end = p + len; len_remaining -= 2; @@ -1557,18 +1558,21 @@ static void print_measurement_pilot_tx(const uint8_t type, uint8_t len, return; } - printf("\t\t * vendor specific: OUI %.2x:%.2x:%.2x, data:", - p[0], p[1], p[2]); - len_remaining -= 3; - - if (len > len_remaining) { + if (len < 3 || len > len_remaining) { printf(" \n"); return; } - while (p < p + len) + printf("\t\t * vendor specific: OUI %.2x:%.2x:%.2x, data:", + p[0], p[1], p[2]); + /* add only two here and use ++p in while loop */ + p += 2; + + while (++p < end) printf(" %.2x", *p); printf("\n"); + + len_remaining -= len; } } -- 2.25.0