Received: by 2002:a25:1506:0:0:0:0:0 with SMTP id 6csp4919620ybv; Tue, 11 Feb 2020 05:56:56 -0800 (PST) X-Google-Smtp-Source: APXvYqyYg1HWh2g7IaVKqVaAzKFid0NBsfkmWfEi5Vvf04p73h5onrZ4fJQv5ks2Dtd5XgfB5E4x X-Received: by 2002:a9d:a68:: with SMTP id 95mr5077351otg.87.1581429416585; Tue, 11 Feb 2020 05:56:56 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1581429416; cv=none; d=google.com; s=arc-20160816; b=kJCRfFpu9mclitpIb6Hgx6xNoOaJ6xq5hxD0aQ8LMZkreKIQCxo2E0nkDY4ecWWn33 fplzRbc/MmqUVWQ8RdNTXvhZD4he8B27VFTL+suZiFF1y5K5jkmewivWlfFQzJ8Xd1JY cbi1uVv+mo2Z1jnL5/5Wj0Ahzz0ORgrhPGRa4pcrbKr3dgOIGIvu9212g19QJZCQuK/N rNJQgFMRhUHldIBleMmpFV3Gnnd86hto2ODXJMbJqExxqY9teljBM1owKuz+Fk2f16z3 USnMkR68Wt86l+eqsG1w41TMRKGuefpooKzQ8qRvT6g2J6wSRYU0saNZc4zBfUT0g2uA gz3w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:user-agent:message-id :in-reply-to:date:references:subject:cc:to:from:dmarc-filter :dkim-signature; bh=DCm1dmFf/tnARUKiqpFNAp0JunUgKPiMRXdckXqP5Yw=; b=B2kTLSAC4IggqlCKQ4l4exHhGn6ehIVA2TK+qfxfoXiaA4TCvMKzB3OYaaj7uLSKhG BuZ/3d1S1WtUJG0pueZz3JLn0YsclaTuf+FIFBCdu38UfSL+4974gmic+KXWb9Yxir6B LcElZn5x09J+PWlukVB8cR01yXKOwtAI3OyE5JyxMiNILnqVpSkeVGjqGCc5kmNHV8fA LWYmbUsE8oket6VgSKabiQn4ZHAL9PPdGewiGcD2DGSEz0dZ9pXNcEEC4OPvqrSFPvAy 7zWLTPFW3w3KA67V7FDzubNmJGR8ZxhPeA99+1g/VHo9dC9ljkvovZbJlU0oqKTLB0jG FcIQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@mg.codeaurora.org header.s=smtp header.b=GGHbyggm; spf=pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id v25si1918938otq.93.2020.02.11.05.56.45; Tue, 11 Feb 2020 05:56:56 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@mg.codeaurora.org header.s=smtp header.b=GGHbyggm; spf=pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729207AbgBKNei (ORCPT + 99 others); Tue, 11 Feb 2020 08:34:38 -0500 Received: from mail25.static.mailgun.info ([104.130.122.25]:39650 "EHLO mail25.static.mailgun.info" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729120AbgBKNeh (ORCPT ); Tue, 11 Feb 2020 08:34:37 -0500 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1581428076; h=Content-Type: MIME-Version: Message-ID: In-Reply-To: Date: References: Subject: Cc: To: From: Sender; bh=DCm1dmFf/tnARUKiqpFNAp0JunUgKPiMRXdckXqP5Yw=; b=GGHbyggmzkC/MaF2XJPoSL6XlGM/SGDZWcgtphjJIk4gK+r3Qilfnq9fMwlcFIUOC31Vla1w UzPgeO4jU4T16RVGuoP55bVSJFU9lZ8BFI9KUL00sUqQ6Gw4tWS2TYHQMraBXO+Rh8qlMBWV fWDHihOZJfGwGVKe0C3cPkMf6KM= X-Mailgun-Sending-Ip: 104.130.122.25 X-Mailgun-Sid: WyI3YTAwOSIsICJsaW51eC13aXJlbGVzc0B2Z2VyLmtlcm5lbC5vcmciLCAiYmU5ZTRhIl0= Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by mxa.mailgun.org with ESMTP id 5e42ad66.7ff552f82490-smtp-out-n01; Tue, 11 Feb 2020 13:34:30 -0000 (UTC) Received: by smtp.codeaurora.org (Postfix, from userid 1001) id EA72CC447A2; Tue, 11 Feb 2020 13:34:29 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-caf-mail-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=2.0 tests=ALL_TRUSTED,SPF_NONE autolearn=unavailable autolearn_force=no version=3.4.0 Received: from potku.adurom.net (88-114-240-156.elisa-laajakaista.fi [88.114.240.156]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: kvalo) by smtp.codeaurora.org (Postfix) with ESMTPSA id 4946AC447A0; Tue, 11 Feb 2020 13:34:28 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 4946AC447A0 Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; spf=none smtp.mailfrom=kvalo@codeaurora.org From: Kalle Valo To: Pradeep Kumar Chitrapu Cc: ath11k@lists.infradead.org, linux-wireless@vger.kernel.org Subject: Re: [PATCH 1/2] ath11k: add thermal cooling device support References: <1580860830-12696-1-git-send-email-pradeepc@codeaurora.org> Date: Tue, 11 Feb 2020 15:34:25 +0200 In-Reply-To: <1580860830-12696-1-git-send-email-pradeepc@codeaurora.org> (Pradeep Kumar Chitrapu's message of "Wed, 5 Feb 2020 05:30:29 +0530") Message-ID: <874kvxxn6m.fsf@kamboji.qca.qualcomm.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Pradeep Kumar Chitrapu writes: > Thermal cooling device support is added to control the temperature by > throttling the data transmission for the given duration. Throttling is > done by suspending all data tx queues by given percentage of time. The > thermal device allows user to configure duty cycle. > > Throttling can be disabled by setting the duty cycle to 0. The cooling > device can be found under /sys/class/thermal/cooling_deviceX/. > Corresponding soft link to this device can be found under phy folder. > > /sys/class/ieee80211/phy*/device/cooling_device. > > To set duty cycle as 40%, > > echo 40 >/sys/class/ieee80211/phy*/device/cooling_device/cur_state > > Signed-off-by: Pradeep Kumar Chitrapu [...] > +++ b/drivers/net/wireless/ath/ath11k/thermal.h > @@ -0,0 +1,40 @@ > +// SPDX-License-Identifier: BSD-3-Clause-Clear This had a warning: drivers/net/wireless/ath/ath11k/thermal.h:1: Improper SPDX comment style for 'drivers/net/wireless/ath/ath11k/thermal.h', please use '/*' instead drivers/net/wireless/ath/ath11k/thermal.h:1: Missing or malformed SPDX-License-Identifier tag in line 1 I fixed that in the pending branch. -- https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches