Received-SPF: pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 63AE8C4479F
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Subject: Re: [PATCH v2 5.5] iwlwifi: mvm: Do not require PHY_SKU NVM section
 for 3168 devices
From:   Kalle Valo <kvalo@codeaurora.org>
In-Reply-To: <20200128093107.9740-1-dmoulding@me.com>
References: <20200128093107.9740-1-dmoulding@me.com>
To:     Dan Moulding <dmoulding@me.com>
Cc:     linux-wireless@vger.kernel.org, johannes.berg@intel.com,
        emmanuel.grumbach@intel.com, luciano.coelho@intel.com,
        linuxwifi@intel.com, Dan Moulding <dmoulding@me.com>
User-Agent: pwcli/0.0.0-git (https://github.com/kvalo/pwcli/) Python/2.7.12
Message-Id: <20200213100340.541F4C4479C@smtp.codeaurora.org>
Date:   Thu, 13 Feb 2020 10:03:40 +0000 (UTC)
Sender: linux-wireless-owner@vger.kernel.org
Precedence: bulk

Dan Moulding <dmoulding@me.com> wrote:

> The logic for checking required NVM sections was recently fixed in
> commit b3f20e098293 ("iwlwifi: mvm: fix NVM check for 3168
> devices"). However, with that fixed the else is now taken for 3168
> devices and within the else clause there is a mandatory check for the
> PHY_SKU section. This causes the parsing to fail for 3168 devices.
> 
> The PHY_SKU section is really only mandatory for the IWL_NVM_EXT
> layout (the phy_sku parameter of iwl_parse_nvm_data is only used when
> the NVM type is IWL_NVM_EXT). So this changes the PHY_SKU section
> check so that it's only mandatory for IWL_NVM_EXT.
> 
> Fixes: b3f20e098293 ("iwlwifi: mvm: fix NVM check for 3168 devices")
> Signed-off-by: Dan Moulding <dmoulding@me.com>

Patch applied to wireless-drivers.git, thanks.

a9149d243f25 iwlwifi: mvm: Do not require PHY_SKU NVM section for 3168 devices

-- 
https://patchwork.kernel.org/patch/11353871/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches