Received-SPF: pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Sergey Matyukevich <sergey.matyukevich.os@quantenna.com>
To:     Johannes Berg <johannes@sipsolutions.net>
CC:     "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
Subject: Re: [RFC PATCH 1/2] cfg80211: skip strict validation for UDPATE_OWE
 command
Thread-Topic: [RFC PATCH 1/2] cfg80211: skip strict validation for UDPATE_OWE
 command
Thread-Index: AQHV4kz2Q5s3fb8LT0S52R/D0emqZagY1umAgAAhmIA=
Date:   Thu, 13 Feb 2020 11:13:07 +0000
Message-ID: <20200213111300.jgb3kkvwq6am3aj7@bars>
References: <20200213090657.28841-1-sergey.matyukevich.os@quantenna.com>
 <20200213090657.28841-2-sergey.matyukevich.os@quantenna.com>
 <703b19463655cbb8a5ab9469caec5d3936dbe35d.camel@sipsolutions.net>
In-Reply-To: <703b19463655cbb8a5ab9469caec5d3936dbe35d.camel@sipsolutions.net>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-messagesentrepresentingtype: 1
x-originating-ip: [195.182.157.78]
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 7250a4e4-76d5-4999-0df6-08d7b075b3a9
x-ms-traffictypediagnostic: SN6PR05MB5056:|BYASPR01MB0070:
x-microsoft-antispam-prvs: <SN6PR05MB505675560A28A693412C705FA31A0@SN6PR05MB5056.namprd05.prod.outlook.com>
x-moderation-data: 2/13/2020 11:13:37 AM
x-ms-oob-tlc-oobclassifiers: OLM:6430;
x-forefront-prvs: 031257FE13
x-forefront-antispam-report: SFV:NSPM;SFS:(10009020)(396003)(39850400004)(376002)(366004)(136003)(346002)(199004)(189003)(55016002)(8936002)(956004)(9686003)(1076003)(478600001)(4744005)(8676002)(81166006)(81156014)(52116002)(6916009)(6496006)(66946007)(66446008)(4326008)(64756008)(66556008)(66476007)(33716001)(71200400001)(186003)(5660300002)(16526019)(26005)(2906002)(316002)(9576002)(86362001);DIR:OUT;SFP:1101;SCL:1;SRVR:BYASPR01MB0070;H:BYAPR05MB4727.namprd05.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;A:1;MX:1;
received-spf: None (protection.outlook.com: quantenna.com does not designate
 permitted sender hosts)
x-ms-exchange-senderadcheck: 1
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: 8mlYUcvO73wyzLdQ8lJBAWohAym0ZK8LrAeC7HJnHIMtUVG4rWR9Px1g046dWH+MvVwmFMwrlb7QNo1voHLTFg+kvSqFm20JR59DG6yIkc6chkTswnxBrEjH7nufEZIjJE/utOvQy188c/ltxrNF+L6bvnHZVswN1niSLJgo0leVyPq6WoDBFMHZmrv+nHYG956c9dHWS7bldgIrUPoUfxzNCRArslR69GutmNmDkhJMBrXLuwptk4CWR03+Yzdm08NI39x+rINUI+lYp0wFc92k6oD1Jo6T0ee7yILp2Qu87k2Hsc1Ok6S+asjC2+TKXA6jJkzQb8juOBflkOxhtJ/K3Pb4tYbaVNiAYBHgK2kaRZCwDEHOY9ynJL5gYiiTe4hWfDG1WS3ytV5p1KQCAaFVTNgxuphv9PXPrCBlNA1OBkybrG/6kJq8ig198JyD
x-ms-exchange-antispam-messagedata: IGzrDzH20FzDV0vK6MVfMjF2rom2YSnt1Iga1U4G+euFzLrcrTTJqBC8SzNnLf9U67TJjqv1VjWUfRgJT9Tr3hOl533QRq/oOIct7/Nh+jEHI308Cc75Hv8RdtntjjAjV30eFbSsOJlcNoJ9giregw==
x-ms-exchange-transport-forked: True
Content-Type: text/plain; charset="us-ascii"
Content-ID: <AA22C7B6BB981247884EE3782342B7E1@namprd05.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: quantenna.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 7250a4e4-76d5-4999-0df6-08d7b075b3a9
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: a355dbce-62b4-4789-9446-c1d5582180ff
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: sOqZz0DzbJBsJdXFKlMj8gl5NSbKHvOa5nT6Hax2kKB4sKZqOddhm9uN6iKqg+OU4wscRCwKQ8i3xLAJ+lT9vdQx0ffmvHmRK+8Ay52mq7FWIDRx0FlmbrGn/rjfq9/dqr8+butmRz4pXjD7tEsmqFODH1h0L5r/p51p+9jFf6t0fioMVydi/OF7sv0bpd9vbTlVLFOKcPGUNTW4wWAkEyW74A8vPRtM4JTI9lqUdYw=
X-MS-Exchange-CrossTenant-originalarrivaltime: 13 Feb 2020 11:13:40.6858
 (UTC)
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYASPR01MB0070
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.138,18.0.572
 definitions=2020-02-13_03:2020-02-12,2020-02-13 signatures=0
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 lowpriorityscore=0 priorityscore=1501
 bulkscore=0 suspectscore=0 malwarescore=0 mlxlogscore=936 mlxscore=0
 adultscore=0 impostorscore=0 spamscore=0 phishscore=0 clxscore=1015
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2001150001
 definitions=main-2002130089
Sender: linux-wireless-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-wireless.vger.kernel.org>
X-Mailing-List: linux-wireless@vger.kernel.org

On Thu, Feb 13, 2020 at 10:12:47AM +0100, Johannes Berg wrote:
>=20
> [External Email]: This email arrived from an external source - Please exe=
rcise caution when opening any attachments or clicking on links.
>=20
> On Thu, 2020-02-13 at 09:07 +0000, Sergey Matyukevich wrote:
> > Do not perform strict validation of UPDATE_OWE command.
> > Otherwise, kernel rejects command executed by hostapd.
>=20
> Can't we fix hostapd? I mean, it's a relatively new command, so why
> shouldn't we validate it strictly?

That is why this patch is RFC: see cover email :)

Sure, I can fix hostapd instead. Could you point me at some good
starting point to look at ? Are there any user-space tools that
started to use strict validation ?

P.S.
If you are ok with the second patch, then could you just take it
from this series ? Or should I resubmit ?

Regards,
Sergey