Received-SPF: pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Reply-To: chi-hsien.lin@cypress.com
Subject: Re: [PATCH 3/6] brcmfmac: fix the incorrect return value in
 brcmf_inform_single_bss().
To:     Arend Van Spriel <arend.vanspriel@broadcom.com>,
        linux-wireless@vger.kernel.org
Cc:     brcm80211-dev-list@broadcom.com, brcm80211-dev-list@cypress.com,
        Franky Lin <franky.lin@broadcom.com>,
        Hante Meuleman <hante.meuleman@broadcom.com>,
        Wright Feng <wright.feng@cypress.com>,
        Kalle Valo <kvalo@codeaurora.org>,
        Raveendran Somu <raveendran.somu@cypress.com>
References: <1581583476-60155-1-git-send-email-chi-hsien.lin@cypress.com>
 <1581583476-60155-4-git-send-email-chi-hsien.lin@cypress.com>
 <6c45797d-840b-5835-55fd-572c2b2abde7@broadcom.com>
From:   Chi-Hsien Lin <chi-hsien.lin@cypress.com>
Message-ID: <166b1990-c693-dd6e-68ef-add2878c21c5@cypress.com>
Date:   Fri, 14 Feb 2020 22:56:53 +0800
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101
 Thunderbird/52.9.1
In-Reply-To: <6c45797d-840b-5835-55fd-572c2b2abde7@broadcom.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
Received-SPF: None (protection.outlook.com: cypress.com does not designate
 permitted sender hosts)
X-MS-Exchange-CrossTenant-Network-Message-Id: 5bb4c12c-f950-4a2f-e7a4-08d7b15e2464
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Feb 2020 14:56:59.5247
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 011addfc-2c09-450d-8938-e0bbc2dd2376
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: nctaF9jgUrl+VnwtWqjvPszEsGXr2WZ+7fcLiDCvMjrg7xPeg6m6buPusE7G2NWVKgz5Um4C+F9A3rPrIWDhUA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR06MB5992
Sender: linux-wireless-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-wireless.vger.kernel.org>
X-Mailing-List: linux-wireless@vger.kernel.org


On 02/13/2020 5:30, Arend Van Spriel wrote:
> On 2/13/2020 9:44 AM, Chi-Hsien Lin wrote:
>> From: Raveendran Somu <raveendran.somu@cypress.com>
>>
>> The function brcmf_inform_single_bss returns the value as success,
>> even when the length exceeds the maximum value.
>> The fix is to send appropriate code on this error.
>> This issue is observed when SVT reported random fmac crashes
>> when running their tests and the path was identified from the
>> crash logs. With this fix the random failure issue in SVT was
>> resolved.
> 
> Although I know what SVT is it not clear in a public commit message. 
> Just refer to "Broadcom test group" or something similar. It would be 
> good to have the crash log in the commit message though. I suspect it 
> occurs upon next_bss_le() call, but having the crash log is better than 
> having me guess. Anyway, here is my...
> 
> Reviewed-by: Arend van Spriel <arend.vanspriel@broadcom.com>

Arend,

Thanks a lot for the feedback. I'll update the comment in V2. This is an 
issue that we solved a while back. I'll do some search and see if I can 
find the crash log.

Regards,
Chi-hsien Lin

> 
> Regards,
> Arend
> .
>