Received-SPF: pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: Commit d1d1a96 in rtl8188ee module causes issues when connecting
 to my institute's wifi
To:     Ashish <ashishkumar.yadav@students.iiserpune.ac.in>,
        linux-wireless@vger.kernel.org
References: <4830c992-1a09-9989-ab29-ea403b910551@students.iiserpune.ac.in>
From:   Larry Finger <Larry.Finger@lwfinger.net>
Message-ID: <d36d4847-8e01-e8f0-bf22-9fb53de5861c@lwfinger.net>
Date:   Wed, 19 Feb 2020 11:01:32 -0600
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.5.0
MIME-Version: 1.0
In-Reply-To: <4830c992-1a09-9989-ab29-ea403b910551@students.iiserpune.ac.in>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-wireless-owner@vger.kernel.org
Precedence: bulk

On 2/19/20 2:55 AM, Ashish wrote:
> The commit d1d1a96 (at 
> https://github.com/torvalds/linux/commit/d1d1a96bdb4408d02e2bfcb32b71aba165458a80?diff=unified) 
> in rtl8188ee module causes problems while connecting to my institute's wifi. I 
> am not able to connect to that wifi after this commit. The journalctl output is 
> at http://ix.io/28IX (look for "AP off, try to reconnect now").
> 
> The problem is with removal of the struct. Adding the struct back in trx.h 
> solves the issue.
> 

As I have discussed with you in the other venues, that struct was never used, 
and the only way it could have caused any effect is if the alignment of struct 
phy_status_rpt is  critical in some way I do not understand.

Please try the patch below and report back. That will restore the alignment 
without all that mumbo-jumbo about little- vs big-endian.

diff --git a/drivers/net/wireless/realtek/rtlwifi/rtl8188ee/trx.h 
b/drivers/net/wireless/realtek/rtlwifi/rtl8188ee/trx.h
index 917729807514..e17f70b4d199 100644
--- a/drivers/net/wireless/realtek/rtlwifi/rtl8188ee/trx.h
+++ b/drivers/net/wireless/realtek/rtlwifi/rtl8188ee/trx.h
@@ -561,6 +561,7 @@ static inline void clear_pci_tx_desc_content(__le32 
*__pdesc, int _size)
          rxmcs == DESC92C_RATE11M)

  struct phy_status_rpt {
+       u8      padding[2];
         u8      ch_corr[2];
         u8      cck_sig_qual_ofdm_pwdb_all;
         u8      cck_agc_rpt_ofdm_cfosho_a;

Larry