Received-SPF: pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Received-SPF: Pass (esa1.microchip.iphmx.com: domain of
  Ajay.Kathat@microchip.com designates 198.175.253.82 as
  permitted sender) identity=mailfrom;
  client-ip=198.175.253.82; receiver=esa1.microchip.iphmx.com;
  envelope-from="Ajay.Kathat@microchip.com";
  x-sender="Ajay.Kathat@microchip.com"; x-conformance=spf_only;
  x-record-type="v=spf1"; x-record-text="v=spf1 mx
  a:ushub1.microchip.com a:smtpout.microchip.com
  -exists:%{i}.spf.microchip.iphmx.com include:servers.mcsv.net
  include:mktomail.com include:spf.protection.outlook.com ~all"
Received-SPF: None (esa1.microchip.iphmx.com: no sender
  authenticity information available from domain of
  postmaster@email.microchip.com) identity=helo;
  client-ip=198.175.253.82; receiver=esa1.microchip.iphmx.com;
  envelope-from="Ajay.Kathat@microchip.com";
  x-sender="postmaster@email.microchip.com";
  x-conformance=spf_only
IronPort-SDR: AlwehkzjSqdMyyv2PrWR4jDQwODJvbdfYrqxncW2N44JQ5KfMy/3/htnYHaEgFffF9HqhlRK4j
 sAOF/SWff4vC7PQ8uO68EIDZ9eip4ny6ij7FuFTTybS6zLZdg4JDXx8W5U4z68Gj1/52PP49k+
 EzU4MyZQrRjMkZQouirF/7vT5ru30yWXmHZso6Rm6IdE35Fzq81e2pZBBQVJDHwp3xFOZXveVD
 lWUroJ06H6FWlOJ16dhNC2Jh2u/Ao2/Wsr7oBUJPiSkpTmkrbWbAwrxBn0Don63NwY0O41jM1r
 Qrg=
From:   <Ajay.Kathat@microchip.com>
To:     <linux-wireless@vger.kernel.org>
CC:     <devel@driverdev.osuosl.org>, <gregkh@linuxfoundation.org>,
        <Adham.Abozaeid@microchip.com>, <johannes@sipsolutions.net>,
        <Ajay.Kathat@microchip.com>
Subject: [PATCH] staging: wilc1000: avoid double unlocking of 'wilc->hif_cs'
 mutex
Thread-Topic: [PATCH] staging: wilc1000: avoid double unlocking of
 'wilc->hif_cs' mutex
Thread-Index: AQHV6KpMhXZfgCJaNUWE+Dn1HLC0EQ==
Date:   Fri, 21 Feb 2020 11:30:20 +0000
Message-ID: <20200221170120.15739-1-ajay.kathat@microchip.com>
Accept-Language: en-US
Content-Language: en-US
received-spf: None (protection.outlook.com: microchip.com does not designate
 permitted sender hosts)
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 01b38dd2-f54a-4b92-2a7e-08d7b6c16f7c
X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Feb 2020 11:30:21.0386
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 3f4057f3-b418-4d4e-ba84-d55b4e897d88
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 7NNxcnfVzN6Z/ZeMRsgyBqU9tT+LtqVu8JrORidw7NtNotJO4CR1mhCHOzUfuUuntI6fM8FsFpDHO5gBXv4jVDjW9Uyu/foDJv351I5hRBc=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR11MB4151
Sender: linux-wireless-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-wireless.vger.kernel.org>
X-Mailing-List: linux-wireless@vger.kernel.org

From: Ajay Singh <ajay.kathat@microchip.com>

Possible double unlocking of 'wilc->hif_cs' mutex was identified by
smatch [1]. Removed the extra call to release_bus() in
wilc_wlan_handle_txq() which was missed in earlier commit fdc2ac1aafc6
("staging: wilc1000: support suspend/resume functionality").

[1]. https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org/thread/NO=
EVW7C3GV74EWXJO3XX6VT2NKVB2HMT/

Reported-by: kbuild test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Ajay Singh <ajay.kathat@microchip.com>
---
 drivers/staging/wilc1000/wlan.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/staging/wilc1000/wlan.c b/drivers/staging/wilc1000/wla=
n.c
index f633c6b9f0a9..3aeca882f431 100644
--- a/drivers/staging/wilc1000/wlan.c
+++ b/drivers/staging/wilc1000/wlan.c
@@ -575,7 +575,6 @@ int wilc_wlan_handle_txq(struct wilc *wilc, u32 *txq_co=
unt)
 				entries =3D FIELD_GET(WILC_VMM_ENTRY_COUNT, reg);
 				break;
 			}
-			release_bus(wilc, WILC_BUS_RELEASE_ALLOW_SLEEP);
 		} while (--timeout);
 		if (timeout <=3D 0) {
 			ret =3D func->hif_write_reg(wilc, WILC_HOST_VMM_CTL, 0x0);
--=20
2.24.0