Received-SPF: pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Message-ID: <8a1516685201cc25cdcb8ac0016e0b5f30401f2f.camel@sipsolutions.net>
Subject: Re: [PATCH 1/7] cfg80211: More error messages for key addition
 failures
From:   Johannes Berg <johannes@sipsolutions.net>
To:     Jouni Malinen <jouni@codeaurora.org>
Cc:     linux-wireless@vger.kernel.org
Date:   Sat, 22 Feb 2020 17:17:44 +0100
In-Reply-To: <20200222132548.20835-1-jouni@codeaurora.org>
References: <20200222132548.20835-1-jouni@codeaurora.org>
Content-Type: text/plain; charset="UTF-8"
User-Agent: Evolution 3.34.2 (3.34.2-1.fc31) 
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-wireless-owner@vger.kernel.org
Precedence: bulk

On Sat, 2020-02-22 at 15:25 +0200, Jouni Malinen wrote:
> 
> -	if (!err)
> +	if (err)
> +		GENL_SET_ERR_MSG(info, "key not allowed");
> +	if (!err) {
>  		err = rdev_add_key(rdev, dev, key.idx,

[...]

Had to read this twice, but I don't see any reason not to put an else
there? :)

I can fix it up later when I apply it.

Thanks, btw, BIGTK was definitely something we were also looking into
now.

johannes