Received-SPF: pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Message-ID: <685a6b65ed480fc6edc151eafb4445f5d1884bd0.camel@sipsolutions.net>
Subject: Re: [PATCH v4 6/7] rtw88: Add wowlan pattern match support
From:   Johannes Berg <johannes@sipsolutions.net>
To:     Brian Norris <briannorris@chromium.org>
Cc:     Tony Chuang <yhchuang@realtek.com>,
        Kalle Valo <kvalo@codeaurora.org>,
        linux-wireless <linux-wireless@vger.kernel.org>,
        Chris Chiu <chiu@endlessm.com>
Date:   Mon, 24 Feb 2020 22:35:45 +0100
In-Reply-To: <CA+ASDXPP31bXpjvYz=hbR_WmwbXb77NRodgSThcxnDgME5vFJg@mail.gmail.com> (sfid-20200224_223408_581404_6B6EE4CF)
References: <20191219085816.20709-1-yhchuang@realtek.com>
         <20191219085816.20709-7-yhchuang@realtek.com>
         <20200222005242.GA100360@google.com>
         <d7c4c85ca707118a612a34607b4980b2448f2059.camel@sipsolutions.net>
         <CA+ASDXPP31bXpjvYz=hbR_WmwbXb77NRodgSThcxnDgME5vFJg@mail.gmail.com>
         (sfid-20200224_223408_581404_6B6EE4CF)
Content-Type: text/plain; charset="UTF-8"
User-Agent: Evolution 3.34.2 (3.34.2-1.fc31) 
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-wireless-owner@vger.kernel.org
Precedence: bulk

On Mon, 2020-02-24 at 13:33 -0800, Brian Norris wrote:
> 
> > if not, IMHO better to add some
> > advertisement bits, but if not then we can surely add some kind of
> > filter callback that's invoked at config time, rather than only at
> > suspend time when it's way too late to do anything about it.
> 
> Yeah, I'd have to see what sort of restrictions we're working with --
> sufficiently complex rules might not make for good "advertisement"
> bits.

Agree. And we've certainly gotten better at spelling out what exactly
when wrong since all this started - the "extended ACK" bits I wrote that
can include an error message and can point to the bad attribute still
feel sort of new to me, even if we've had them for a few years :)

So if we end up going with a callback, we should probably include an
extack pointer for the driver to fill up ...

johannes