Received: by 2002:a25:c205:0:0:0:0:0 with SMTP id s5csp6277290ybf; Thu, 5 Mar 2020 17:07:21 -0800 (PST) X-Google-Smtp-Source: ADFU+vubv6uqDsiBmERHotxtTobsSDo3F9Wln2SPQZUAaFTBcVY03vvNz3nmyhihHE7RdbIGiohv X-Received: by 2002:aca:5303:: with SMTP id h3mr898377oib.74.1583456841353; Thu, 05 Mar 2020 17:07:21 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1583456841; cv=none; d=google.com; s=arc-20160816; b=UKRsrzc2wNGqbNTRi0uJTHp/IwuUT9MnoM29CRfdcHLDGeU7bvTDnXDRUBmZgXB5Wn RunA9+83yGXboFR2FDHFB8w0PeXThap5uEmlQJMD4yu/HSBEBM5cz4wMJ6xw7pbqS4fo l2NvpXegnHA/lHEtXZm57IKDf1cv2VzIeGcVXdcxIPoSBYG/MGrY/tKmyAMf3i3mGpEP Bn2Tmn8SQbTIF0aTQyrS8EX32XRTBmTV7LL+tFle7D6U/202IUbvWmPaTgqdWrZWAoyu DUeVQAeofMoCcpknbbmSCpDVgnaDwOQbFACkwNSTI/IozSxkdloIIhVLYtvTXIpSL3Hp pECQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=f5YVJLSzzGieeFgEWE1bPSAn5fpUlz4W6z/rvH4BAMM=; b=eDfsyguCo2c/WW1Xg62bQPuVCIsXkLyDWbF9NtWYjwAVpFMPLGwPDX1OAl1WfBG0g5 D3udCHBhvquizc7x796M/NEGLSfG99Nv6QDEcKtmJVLuVvSFLl0WBQW1XR/Hk/a+ybX0 VX77S6bMWvslkkGweRJVUQ35mrSKvDaOwVnArWtmIAeZkE+AqFGC4eUqUQJjVQ1jB1Vm CzCAmEhsozTPeGpoEwLdxPJrP5HcGqFDosqaOi1xdlDolF/y1qie1/9f7dU71cfKjwRK p1b2cPZllFW+4tWnXws5XeXd1aioBd4bSmJoOHa74rNORiyOCzpJLIeW6my+Eg9e3PAv g04Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=eDv4q92M; spf=pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id i8si363044otr.227.2020.03.05.17.06.56; Thu, 05 Mar 2020 17:07:21 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=eDv4q92M; spf=pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726769AbgCFBGv (ORCPT + 99 others); Thu, 5 Mar 2020 20:06:51 -0500 Received: from mail.kernel.org ([198.145.29.99]:59366 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726485AbgCFBGu (ORCPT ); Thu, 5 Mar 2020 20:06:50 -0500 Received: from kicinski-fedora-PC1C0HJN.thefacebook.com (unknown [163.114.132.128]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id CBE7E208C3; Fri, 6 Mar 2020 01:06:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1583456809; bh=BFAz6k8N2AgaW0pXpCjlxC1XrQ/2bd8PY1PxlDWovR0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=eDv4q92MORThFDshgMnFSWnN8110Mhqn0qrE54dC9E9Y+VvvVknnafFvOnuYH/ZKD gmYxPMTC8cTzqhFWwwQSMS+YQORfDP0IGiQRhC/0UBDTJpDSpQwDKTs4Q+Nzn/qODN a2RcZc51Zeqqp6AIeWQOrvJk1S0sJ8uHzQhK90BY= From: Jakub Kicinski To: davem@davemloft.net Cc: jdike@addtoit.com, richard@nod.at, anton.ivanov@cambridgegreys.com, linux-um@lists.infradead.org, dledford@redhat.com, jgg@ziepe.ca, leon@kernel.org, linux-rdma@vger.kernel.org, edumazet@google.com, jasowang@redhat.com, mkubecek@suse.cz, hayeswang@realtek.com, doshir@vmware.com, pv-drivers@vmware.com, manishc@marvell.com, GR-Linux-NIC-Dev@marvell.com, gregkh@linuxfoundation.org, merez@codeaurora.org, kvalo@codeaurora.org, linux-wireless@vger.kernel.org, netdev@vger.kernel.org, Jakub Kicinski Subject: [PATCH net-next 2/7] RDMA/ipoib: reject unsupported coalescing params Date: Thu, 5 Mar 2020 17:05:57 -0800 Message-Id: <20200306010602.1620354-3-kuba@kernel.org> X-Mailer: git-send-email 2.24.1 In-Reply-To: <20200306010602.1620354-1-kuba@kernel.org> References: <20200306010602.1620354-1-kuba@kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Set ethtool_ops->supported_coalesce_params to let the core reject unsupported coalescing parameters. This driver did not previously reject unsupported parameters. Signed-off-by: Jakub Kicinski --- drivers/infiniband/ulp/ipoib/ipoib_ethtool.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/infiniband/ulp/ipoib/ipoib_ethtool.c b/drivers/infiniband/ulp/ipoib/ipoib_ethtool.c index 63e4f9d15fd9..a10a0c2ca2da 100644 --- a/drivers/infiniband/ulp/ipoib/ipoib_ethtool.c +++ b/drivers/infiniband/ulp/ipoib/ipoib_ethtool.c @@ -213,6 +213,8 @@ static int ipoib_get_link_ksettings(struct net_device *netdev, } static const struct ethtool_ops ipoib_ethtool_ops = { + .supported_coalesce_params = ETHTOOL_COALESCE_RX_USECS | + ETHTOOL_COALESCE_RX_MAX_FRAMES, .get_link_ksettings = ipoib_get_link_ksettings, .get_drvinfo = ipoib_get_drvinfo, .get_coalesce = ipoib_get_coalesce, -- 2.24.1