Received: by 2002:a25:c205:0:0:0:0:0 with SMTP id s5csp6277293ybf; Thu, 5 Mar 2020 17:07:21 -0800 (PST) X-Google-Smtp-Source: ADFU+vs6Q7WnHfa2Ez84wW5AtPtZtkT90EpMe91w8nautl+1KhNLJAqZI8VGaioT8TGClMxCmFGp X-Received: by 2002:a9d:6951:: with SMTP id p17mr532215oto.24.1583456841351; Thu, 05 Mar 2020 17:07:21 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1583456841; cv=none; d=google.com; s=arc-20160816; b=qMBxvfkAd65aMW2yJQTtyColjw+Q/p+xlBwfDVsM07Z9yGpvXN8P9xO5rcIqpAPvRy OvJsKUtqwMtwWejSnAuJ0cN+54YE9eFjTaVoxOgaWll+S0VfBH9Z/EJQZyF4o3MOVLCh Cvi0CenD6pgnNf/P6K2uMod/cZDz3PAvXAeq1ze31nrBzeIf8a85ZK1tXgp36vavo+pP CnUwLtfv8sRUBq/tT5YuKnMrp/TqbQ39dci7OUooTbvutauXiGcb9UaybLLegvHJgyCJ 4JI/sqhLwaJuXkFn/VXnpji9hPkGLMUqX0kIPAAgevXhILTHX75r8SuLvgvWPF5INg/4 l/UA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=cDE4OeuzZwPyTsCTW6jLqrNdgR3oADxfLCzKX5V0H0I=; b=xJPcF3shDTudZpFf946C9x9DHZVUdloXE4wvVJFHXl268Yj6511MIEuyhcpfzi2j4S 7dzdEwpeCPEDs+yWVx3dS84qu4IwzD8Yqv18t85gMsZGtSwUnWr8DkI/8sSCR9Jmscvo 64yzG5xFstDq9EItb7Qn0dHynksaH6ESmp/LXUSdMHVHS/vojm76I2t/OoTHYD8VgcRT ywX/TP64mZoYl7+uLGl3we52Gp6Zn2MBCZqR5qF0GKTPviG8k5Z6UWiwl2QBy/EnIy7e YN23UxTXlQVHfHixSPhQ9rQce0rlQYCDfjdkAyN6hKsNgak97bPhac1VRGCKtKGMhkaG dilA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=xdk2QAQZ; spf=pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id m17si416978otk.113.2020.03.05.17.07.06; Thu, 05 Mar 2020 17:07:21 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=xdk2QAQZ; spf=pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726974AbgCFBG5 (ORCPT + 99 others); Thu, 5 Mar 2020 20:06:57 -0500 Received: from mail.kernel.org ([198.145.29.99]:59474 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726860AbgCFBGw (ORCPT ); Thu, 5 Mar 2020 20:06:52 -0500 Received: from kicinski-fedora-PC1C0HJN.thefacebook.com (unknown [163.114.132.128]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 080BE21556; Fri, 6 Mar 2020 01:06:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1583456811; bh=t6+kueVIWNtLUqViCk3MdqFhB51exWacT2hvYbn4hoc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=xdk2QAQZ24xQ+XNnceK3ptrcg2bWbXOcr9edHCgW/cXLqloNOsBzFBFHkh9fZ17u/ UTSOplONajI9FemA3ollW3gpdBxDi42uXizDTyOzUnVChUfYu9ictQzzt1NcQhxxKi mlXYnjjf8vCnK3wYVfT27cEmWiwwbI1lNXUchhlQ= From: Jakub Kicinski To: davem@davemloft.net Cc: jdike@addtoit.com, richard@nod.at, anton.ivanov@cambridgegreys.com, linux-um@lists.infradead.org, dledford@redhat.com, jgg@ziepe.ca, leon@kernel.org, linux-rdma@vger.kernel.org, edumazet@google.com, jasowang@redhat.com, mkubecek@suse.cz, hayeswang@realtek.com, doshir@vmware.com, pv-drivers@vmware.com, manishc@marvell.com, GR-Linux-NIC-Dev@marvell.com, gregkh@linuxfoundation.org, merez@codeaurora.org, kvalo@codeaurora.org, linux-wireless@vger.kernel.org, netdev@vger.kernel.org, Jakub Kicinski Subject: [PATCH net-next 4/7] r8152: reject unsupported coalescing params Date: Thu, 5 Mar 2020 17:05:59 -0800 Message-Id: <20200306010602.1620354-5-kuba@kernel.org> X-Mailer: git-send-email 2.24.1 In-Reply-To: <20200306010602.1620354-1-kuba@kernel.org> References: <20200306010602.1620354-1-kuba@kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Set ethtool_ops->supported_coalesce_params to let the core reject unsupported coalescing parameters. This driver did not previously reject unsupported parameters. Signed-off-by: Jakub Kicinski --- drivers/net/usb/r8152.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/usb/r8152.c b/drivers/net/usb/r8152.c index b8d2722a1b33..f27fdd6ab86f 100644 --- a/drivers/net/usb/r8152.c +++ b/drivers/net/usb/r8152.c @@ -6345,6 +6345,7 @@ static int rtl8152_set_ringparam(struct net_device *netdev, } static const struct ethtool_ops ops = { + .supported_coalesce_params = ETHTOOL_COALESCE_USECS, .get_drvinfo = rtl8152_get_drvinfo, .get_link = ethtool_op_get_link, .nway_reset = rtl8152_nway_reset, -- 2.24.1