Received: by 2002:a25:c205:0:0:0:0:0 with SMTP id s5csp6277608ybf; Thu, 5 Mar 2020 17:07:43 -0800 (PST) X-Google-Smtp-Source: ADFU+vsdNTbCeUOeZkqccG4o47ULl0/IoC8eVKN1QqtoksQzSHzFJe3J47Qrs6qHMjKdcXb8T2B/ X-Received: by 2002:aca:b60a:: with SMTP id g10mr877993oif.102.1583456863458; Thu, 05 Mar 2020 17:07:43 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1583456863; cv=none; d=google.com; s=arc-20160816; b=DoHlnw29dhVLPNg8g+sNuVphF7KVs2refNlADih2+tolXVBQAaI3vTvLnm3+Hmc7HN /hRfun1wJkRAbPBy96BDPZDxz/cl+cwew7nd+mtpSmOa6/PKi7mqzXZ5PbRs46tD0c2U V76izFxizTPMQ4BTuDLEwMng+OmhwYMrMto525bY03oOZ6J+mcNLBo9M9VEZEyFW8c8L plSTa5CCSLt+vMqliOk0RZULvsqNtk4/1xUuznbKSsSrJTMjT3DhtnLW8Eodaedsva88 wt+6/zHrW/LqjW4Ke0mb7LBN5rYUJb9ncg6LuyWk1ho3Pj+RrNQdjnI80zJ4B4tcWXpX zsnw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=krgSAmj/4t2QKAoLsRQZJORtz37D2rc7Fyv2B49JOH0=; b=nDRteTx+n8sBfVJz8CnkhuTELLbfWAeJbvCBHC1IpKnEwY05S+l7R6l9h6x9tk3imo 8zTvX5NBR6AfSzZkqzdt0ri+TqyB/KJYsscD9ODhU/vTmAsZ6zgfQmgrMam7abywDcgU qVuQFJ0vATmMz8t2JfoTx8d4Tm9Ny916RE4XF4O/UJqErWuUgd8ck91rv7YFW/d4HE4Z WhwmylXtvpfYO0iFfO81crIZNCKT3iZlbwI0BmVdk3cy8EodEeyf08HI87J1ykQ8B5fv 1+21kaKeAdmLECbOATLmWEEXGMNTvIj2egMMR7nGKToSkO1sbps2mi4Bz7NN2pzg90uU k9Cg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=Bcn4aEmn; spf=pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id d22si338558oti.316.2020.03.05.17.07.32; Thu, 05 Mar 2020 17:07:43 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=Bcn4aEmn; spf=pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726887AbgCFBG4 (ORCPT + 99 others); Thu, 5 Mar 2020 20:06:56 -0500 Received: from mail.kernel.org ([198.145.29.99]:59554 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726358AbgCFBGy (ORCPT ); Thu, 5 Mar 2020 20:06:54 -0500 Received: from kicinski-fedora-PC1C0HJN.thefacebook.com (unknown [163.114.132.128]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 35ED52166E; Fri, 6 Mar 2020 01:06:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1583456814; bh=RM7eXOLghBAxQOombdSNP2dy3sQBpkjdvLa0D3I5Dyo=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Bcn4aEmn6bdLy0jeeEaeMUpU/remFlYp2vgolj4RincgisqfFU4CEObnwDDWJfkXF I9FhD5DBaK11ROE+9WHsVbpX/6YaAwm8hgayvhrcPeuwu+7s57NsL0vip2x5TultwU jsVJO4cG3fiOZD4dHEPaEI3jSr7o7OfEOHtq63Kw= From: Jakub Kicinski To: davem@davemloft.net Cc: jdike@addtoit.com, richard@nod.at, anton.ivanov@cambridgegreys.com, linux-um@lists.infradead.org, dledford@redhat.com, jgg@ziepe.ca, leon@kernel.org, linux-rdma@vger.kernel.org, edumazet@google.com, jasowang@redhat.com, mkubecek@suse.cz, hayeswang@realtek.com, doshir@vmware.com, pv-drivers@vmware.com, manishc@marvell.com, GR-Linux-NIC-Dev@marvell.com, gregkh@linuxfoundation.org, merez@codeaurora.org, kvalo@codeaurora.org, linux-wireless@vger.kernel.org, netdev@vger.kernel.org, Jakub Kicinski Subject: [PATCH net-next 6/7] staging: qlge: reject unsupported coalescing params Date: Thu, 5 Mar 2020 17:06:01 -0800 Message-Id: <20200306010602.1620354-7-kuba@kernel.org> X-Mailer: git-send-email 2.24.1 In-Reply-To: <20200306010602.1620354-1-kuba@kernel.org> References: <20200306010602.1620354-1-kuba@kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Set ethtool_ops->supported_coalesce_params to let the core reject unsupported coalescing parameters. This driver did not previously reject unsupported parameters. Signed-off-by: Jakub Kicinski --- drivers/staging/qlge/qlge_ethtool.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/staging/qlge/qlge_ethtool.c b/drivers/staging/qlge/qlge_ethtool.c index 790997aff995..050c0da23c6f 100644 --- a/drivers/staging/qlge/qlge_ethtool.c +++ b/drivers/staging/qlge/qlge_ethtool.c @@ -714,6 +714,8 @@ static void ql_set_msglevel(struct net_device *ndev, u32 value) } const struct ethtool_ops qlge_ethtool_ops = { + .supported_coalesce_params = ETHTOOL_COALESCE_USECS | + ETHTOOL_COALESCE_MAX_FRAMES, .get_drvinfo = ql_get_drvinfo, .get_wol = ql_get_wol, .set_wol = ql_set_wol, -- 2.24.1