Received-SPF: pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH net-next 3/7] tun: reject unsupported coalescing params
To:     Jakub Kicinski <kuba@kernel.org>, davem@davemloft.net
Cc:     jdike@addtoit.com, richard@nod.at, anton.ivanov@cambridgegreys.com,
        linux-um@lists.infradead.org, dledford@redhat.com, jgg@ziepe.ca,
        leon@kernel.org, linux-rdma@vger.kernel.org, edumazet@google.com,
        mkubecek@suse.cz, hayeswang@realtek.com, doshir@vmware.com,
        pv-drivers@vmware.com, manishc@marvell.com,
        GR-Linux-NIC-Dev@marvell.com, gregkh@linuxfoundation.org,
        merez@codeaurora.org, kvalo@codeaurora.org,
        linux-wireless@vger.kernel.org, netdev@vger.kernel.org
References: <20200306010602.1620354-1-kuba@kernel.org>
 <20200306010602.1620354-4-kuba@kernel.org>
From:   Jason Wang <jasowang@redhat.com>
Message-ID: <36c409f7-a8b4-50f6-4933-1c8105755d11@redhat.com>
Date:   Fri, 6 Mar 2020 17:33:16 +0800
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101
 Thunderbird/60.9.0
MIME-Version: 1.0
In-Reply-To: <20200306010602.1620354-4-kuba@kernel.org>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: quoted-printable
Sender: linux-wireless-owner@vger.kernel.org
Precedence: bulk


On 2020/3/6 =E4=B8=8A=E5=8D=889:05, Jakub Kicinski wrote:
> Set ethtool_ops->supported_coalesce_params to let
> the core reject unsupported coalescing parameters.
>
> This driver did not previously reject unsupported parameters.
>
> Signed-off-by: Jakub Kicinski <kuba@kernel.org>
> ---
>   drivers/net/tun.c | 1 +
>   1 file changed, 1 insertion(+)
>
> diff --git a/drivers/net/tun.c b/drivers/net/tun.c
> index 79f248cb282d..9e8f23519e82 100644
> --- a/drivers/net/tun.c
> +++ b/drivers/net/tun.c
> @@ -3597,6 +3597,7 @@ static int tun_set_coalesce(struct net_device *de=
v,
>   }
>  =20
>   static const struct ethtool_ops tun_ethtool_ops =3D {
> +	.supported_coalesce_params =3D ETHTOOL_COALESCE_RX_MAX_FRAMES,
>   	.get_drvinfo	=3D tun_get_drvinfo,
>   	.get_msglevel	=3D tun_get_msglevel,
>   	.set_msglevel	=3D tun_set_msglevel,


Acked-by: Jason Wang <jasowang@redhat.com>