Received-SPF: pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Message-ID: <9fe23cf27e3c3497073406014d1040bf21450b1f.camel@sipsolutions.net>
Subject: Re: [PATCH mac80211-next] virt_wifi: implement ndo_get_iflink
From:   Johannes Berg <johannes@sipsolutions.net>
To:     Taehee Yoo <ap420073@gmail.com>, linux-wireless@vger.kernel.org,
        Cody Schuffelen <schuffelen@google.com>
Date:   Wed, 11 Mar 2020 09:01:41 +0100
In-Reply-To: <20200305090636.28221-1-ap420073@gmail.com> (sfid-20200305_100646_961996_48E37F6F)
References: <20200305090636.28221-1-ap420073@gmail.com>
         (sfid-20200305_100646_961996_48E37F6F)
Content-Type: text/plain; charset="UTF-8"
User-Agent: Evolution 3.34.2 (3.34.2-1.fc31) 
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-wireless-owner@vger.kernel.org
Precedence: bulk

On Thu, 2020-03-05 at 09:06 +0000, Taehee Yoo wrote:
> ->ndo_get_iflink() is useful for finding lower interface.
> 
> Test commands:
>     ip link add dummy0 type dummy
>     ip link add vw1 link dummy0 type virt_wifi
>     ip link show vw1
> 
> Before:
>     9: vw1: <BROADCAST,MULTICAST> ...
> After:
>     9: vw1@dummy0: <BROADCAST,MULTICAST> ...

So I guess from a netdev layering perspective that makes sense, but I'd
like to hear from Cody if that's really desired from a testing
perspective?

This driver is fundamentally a testing tool and doesn't really have a
place in a production system, so I'd be more likely to look at the
testing needs for this.

Thanks,
johannes