Received-SPF: pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org DA1EDC433CB
From:   Kalle Valo <kvalo@codeaurora.org>
To:     Chris Chiu <chiu@endlessm.com>
Cc:     Tony Chuang <yhchuang@realtek.com>,
        linux-wireless <linux-wireless@vger.kernel.org>,
        Brian Norris <briannorris@chromium.org>
Subject: Re: [PATCH v2 1/2] rtw88: add a debugfs entry to dump coex's info
References: <20200309075852.11454-1-yhchuang@realtek.com>
        <20200309075852.11454-2-yhchuang@realtek.com>
        <CAB4CAwe5kmOOPiw-WBzLMKsXteNgnGzVPsH3pyakg6NfB57Emw@mail.gmail.com>
Date:   Thu, 12 Mar 2020 15:23:59 +0200
In-Reply-To: <CAB4CAwe5kmOOPiw-WBzLMKsXteNgnGzVPsH3pyakg6NfB57Emw@mail.gmail.com>
        (Chris Chiu's message of "Wed, 11 Mar 2020 17:31:48 +0800")
Message-ID: <87blp1u2og.fsf@tynnyri.adurom.net>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
Sender: linux-wireless-owner@vger.kernel.org
Precedence: bulk

Chris Chiu <chiu@endlessm.com> writes:

> On Mon, Mar 9, 2020 at 3:59 PM <yhchuang@realtek.com> wrote:
>>
>> From: Yan-Hsuan Chuang <yhchuang@realtek.com>
>>
>> Add a new entry "coex_info" in debugfs to dump coex's states for
>> us to debug on coex's issues.
>>
>> The basic concept for co-existence (coex, usually for WiFi + BT)
>> is to decide a strategy based on the current status of WiFi and
>> BT. So, it means the WiFi driver requires to gather information
>> from BT side and choose a strategy (TDMA/table/HW settings).
>>
>> Althrough we can easily check the current status of WiFi, e.g.,
>> from kernel log or just dump the hardware registers, it is still
>> very difficult for us to gather so many different types of WiFi
>> states (such as RFE config, antenna, channel/band, TRX, Power
>> save). Also we will need BT's information that is stored in
>> "struct rtw_coex". So it is necessary for us to have a debugfs
>> that can dump all of the WiFi/BT information required.
>>
>> Note that to debug on coex related issues, we usually need a
>> longer period of time of coex_info dump every 2 seconds (for
>> example, 30 secs, so we should have 15 times of coex_info's
>> dump).
>>
>> Signed-off-by: Yan-Hsuan Chuang <yhchuang@realtek.com>

[...]

> Looks good to me. But I strongly suggest using scnprintf instead of
> snprintf to prevent potential buffer overflow.

Yup, please fix that.

-- 
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches