Received-SPF: pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 89FEDC433CB
From:   Kalle Valo <kvalo@codeaurora.org>
To:     Larry Finger <Larry.Finger@lwfinger.net>
Cc:     linux-wireless@vger.kernel.org, pkshih@realtek.com,
        Ashish <ashishkumar.yadav@students.iiserpune.ac.in>
Subject: Re: [PATCH] rtlwifi: rtl8188ee: Fix regression due to commit d1d1a96bdb44
References: <20200219200041.22279-1-Larry.Finger@lwfinger.net>
        <20200312133159.12782C44791@smtp.codeaurora.org>
Date:   Fri, 13 Mar 2020 13:08:45 +0200
In-Reply-To: <20200312133159.12782C44791@smtp.codeaurora.org> (Kalle Valo's
        message of "Thu, 12 Mar 2020 13:31:59 +0000 (UTC)")
Message-ID: <87y2s4se9u.fsf@tynnyri.adurom.net>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
Sender: linux-wireless-owner@vger.kernel.org
Precedence: bulk

Kalle Valo <kvalo@codeaurora.org> writes:

> Larry Finger <Larry.Finger@lwfinger.net> wrote:
>
>> For some unexplained reason, commit d1d1a96bdb44 ("rtlwifi: rtl8188ee:
>> Remove local configuration variable") broke at least one system. As
>> the only net effect of the change was to remove 2 bytes from the start
>> of struct phy_status_rpt, this patch adds 2 bytes of padding at the
>> beginning of the struct.
>> 
>> Fixes: d1d1a96bdb44 ("rtlwifi: rtl8188ee: Remove local configuration variable")
>> Cc: Stable <stable@vger.kernel.org>  # V5.4+
>> Reported-by: Ashish <ashishkumar.yadav@students.iiserpune.ac.in>
>> Tested-by: Ashish <ashishkumar.yadav@students.iiserpune.ac.in>
>> Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
>
> Patch applied to wireless-drivers.git, thanks.
>
> c80b18cbb04b rtlwifi: rtl8188ee: Fix regression due to commit d1d1a96bdb44

While writing the pull request for Dave I noticed that the commit log
does not describe the symptoms in any way. I found the report (connect
issues) but in the future please describe the bug from user's point of
view in the commit log, not just the solution.

-- 
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches