Received-SPF: pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <20200313030545.9184-1-mark.asselstine@windriver.com>
In-Reply-To: <20200313030545.9184-1-mark.asselstine@windriver.com>
From:   Mark Asselstine <asselsm@gmail.com>
Date:   Tue, 17 Mar 2020 16:12:15 -0400
Message-ID: <CAPuovEJWzAvCwWQq0E5MACxo=1Dk5pK4YyjH+d0W-bspAMJJQA@mail.gmail.com>
Subject: Re: [PATCH] iwlwifi: set 'free_queue' to the loop variable, not a
 meaningless bool
To:     johannes.berg@intel.com,
        linux-wireless <linux-wireless@vger.kernel.org>,
        luciano.coelho@intel.com
Content-Type: text/plain; charset="UTF-8"
Sender: linux-wireless-owner@vger.kernel.org
Precedence: bulk

Luca,

This is my first time sending a fix for iwlwifi and I haven't seen any
feedback or seen the code merged. Should I have sent this somewhere
else?

Thanks,
Mark

On Thu, Mar 12, 2020 at 11:06 PM Mark Asselstine
<mark.asselstine@windriver.com> wrote:
>
> From: Mark Asselstine <asselsm@gmail.com>
>
> The loop variable 'i' is passed to iwl_mvm_remove_inactive_tids() as
> the queue number to operate on. iwl_mvm_remove_inactive_tids()
> operates on that queue number then returns true if the queue can be
> reused, the returned bool is stored in 'ret'. We do not want to set
> 'free_queue' to the returned bool stored in 'ret' but rather the loop
> variable, so we are actually operating on the right queue through the
> rest of iwl_mvm_inactivity_check() and have it return a proper queue
> number.
>
> Signed-off-by: Mark Asselstine <asselsm@gmail.com>
> ---
>  drivers/net/wireless/intel/iwlwifi/mvm/sta.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/wireless/intel/iwlwifi/mvm/sta.c b/drivers/net/wireless/intel/iwlwifi/mvm/sta.c
> index 9db2555518aa..2fcaf779649a 100644
> --- a/drivers/net/wireless/intel/iwlwifi/mvm/sta.c
> +++ b/drivers/net/wireless/intel/iwlwifi/mvm/sta.c
> @@ -1166,7 +1166,7 @@ static int iwl_mvm_inactivity_check(struct iwl_mvm *mvm, u8 alloc_for_sta)
>                                                    &changetid_queues);
>                 if (ret >= 0 && free_queue < 0) {
>                         queue_owner = sta;
> -                       free_queue = ret;
> +                       free_queue = i;
>                 }
>                 /* only unlock sta lock - we still need the queue info lock */
>                 spin_unlock_bh(&mvmsta->lock);
> --
> 2.20.1
>