Received-SPF: pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH] rtlwifi: v88 firmware files for rtl8192cu
To:     Reto Schneider <code@reto-schneider.ch>, linux-firmware@kernel.org
Cc:     linux-wireless@vger.kernel.org
References: <20200323024500.4090-1-code@reto-schneider.ch>
From:   Larry Finger <Larry.Finger@lwfinger.net>
Message-ID: <83f99512-ac72-642e-e336-c2cdce62634c@lwfinger.net>
Date:   Mon, 23 Mar 2020 09:57:55 -0500
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.5.0
MIME-Version: 1.0
In-Reply-To: <20200323024500.4090-1-code@reto-schneider.ch>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-wireless-owner@vger.kernel.org
Precedence: bulk

On 3/22/20 9:45 PM, Reto Schneider wrote:
> The vendor driver v4.0.1_6911.20130308 includes new firmware files.
> These were extracted from data statements in that driver to form these
> files.
> 
> Signed-off-by: Reto Schneider <code@reto-schneider.ch>
> ---
>   WHENCE                       |  20 ++++++++++++++++++--
>   rtlwifi/rtl8192cufw_A.bin    | Bin 16116 -> 16126 bytes
>   rtlwifi/rtl8192cufw_B.bin    | Bin 16096 -> 16096 bytes
>   rtlwifi/rtl8192cufw_TMSC.bin | Bin 16116 -> 16126 bytes
>   4 files changed, 18 insertions(+), 2 deletions(-)
> 
> diff --git a/WHENCE b/WHENCE
> index 6265e03..d5bde95 100644
> --- a/WHENCE
> +++ b/WHENCE
> @@ -2738,14 +2738,30 @@ Licence: Redistributable. See LICENCE.rtlwifi_firmware.txt for details.
>   
>   --------------------------------------------------------------------------
>   
> -Driver: rtl8192cu - Realtek 802.11n WLAN driver for RTL8192CU
> +Driver: rtl8192cu - Realtek 802.11n WLAN driver for RTL8192CU (fallback)
>   
>   File: rtlwifi/rtl8192cufw.bin
> +
> +Licence: Redistributable. See LICENCE.rtlwifi_firmware.txt for details.
> +
> +--------------------------------------------------------------------------
> +
> +Driver: rtl8192cu - Realtek 802.11n WLAN driver for RTL8192CU
> +
>   File: rtlwifi/rtl8192cufw_A.bin
>   File: rtlwifi/rtl8192cufw_B.bin
>   File: rtlwifi/rtl8192cufw_TMSC.bin
> +Info: From Vendor's rtl8188C_8192C_usb_linux_v4.0.1_6911.20130308 driver
> +      All files extracted from driver/hal/rtl8192c/usb/Hal8192CUHWImg.c
> +      Relevant variables (CONFIG_BT_COEXISTENCE not set):
> +        - rtlwifi/rtl8192cufw_A.bin: Rtl8192CUFwUMCACutImgArray
> +        - rtlwifi/rtl8192cufw_B.bin: Rtl8192CUFwUMCBCutImgArray
> +        - rtlwifi/rtl8192cufw_TMSC.bin: Rtl8192CUFwTSMCImgArray
>   
> -Licence: Redistributable. See LICENCE.rtlwifi_firmware.txt for details.
> +Licence: Allegedly GPLv2, but no source visible.

No, do not change this line. The firmware is NOT GPLv2; however, it can be 
redistributed as LICENCE.rtlwiifi says.

NACK.

Larry