Received: by 2002:a25:6193:0:0:0:0:0 with SMTP id v141csp3829167ybb; Mon, 23 Mar 2020 08:26:15 -0700 (PDT) X-Google-Smtp-Source: ADFU+vstpG4r4PlKVi/oQ2VGI7xzNQSgVjnCgJgANkc4ZslidLutRP6751vvGNn8Oz3XAeUnP9V3 X-Received: by 2002:a9d:3b76:: with SMTP id z109mr17910526otb.335.1584977175773; Mon, 23 Mar 2020 08:26:15 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1584977175; cv=none; d=google.com; s=arc-20160816; b=bmpIMcAaJcOjOm3T1Lf4b+FidFxpTDl7Vh7GoFgXIki30z8zUmfAAcc0bq/fE492eP f431o+OEt+VisChs44NtmIaXbfVQLepdqFgdtT0PI2YGNY06lvCClR6bRS4nCtgE1qN9 f4IJsGIIbNq9NCwD3Fav55RA+5tS5dbbGcXgJ5UGSGqfjvCwaeOrQO+uXriW6zu3LE8g 3Qd7Jk//aALIAu3BMhlM5Cv3oCL9oavgBeW+oUuh8W1f4LhmCzpKWUN/+N12EKA7vgZY eOlp68yA2zL+7isHwE4Kymm+Ke+TTawS1ffnI/sHJ79AAtZgTR+79h//SAnYf4HCFOId E1cA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=ETrVNtL1vDb+1pHa82FI11u9VuQGBRSmHdVznB3LgXA=; b=PGDqEG07w1Dxz+x7BbK93jPd148p9XtpDXy/nBNRaIr4x66e68P3WRKl/vYgIURGn3 pjaSdLByQZB5U7SaFWqQTxzWWbElhwGC3TgxLuTB4+fmU/5KdPjvj2xH0x1Tdmm0B+rP uiRSEQ5GItYaTtwGsODBgFX/gWe3oZZP/cHoE6dXCul5o6fNYDMpSK7NWub2kAGOrrtf ZMfUb1BZJpHdfEgPpSwoZcG24Zg7vzW+6utgmh5mQH+8WZ0ZESOnci/mrNA0tmL1kxP9 gyWTQ/WqwsEg23eX2DyPbP6Cg+Gmwizd4nsSyzoalsDZ3gZMikeH3k3c3rUB9msY1eUR 6dQg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id s1si6996560oij.237.2020.03.23.08.26.04; Mon, 23 Mar 2020 08:26:15 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727338AbgCWPZv (ORCPT + 99 others); Mon, 23 Mar 2020 11:25:51 -0400 Received: from s3.sipsolutions.net ([144.76.43.62]:49324 "EHLO sipsolutions.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727318AbgCWPZv (ORCPT ); Mon, 23 Mar 2020 11:25:51 -0400 Received: by sipsolutions.net with esmtpsa (TLS1.3:ECDHE_X25519__RSA_PSS_RSAE_SHA256__AES_256_GCM:256) (Exim 4.93) (envelope-from ) id 1jGOxZ-002WVN-6V; Mon, 23 Mar 2020 16:25:49 +0100 From: Johannes Berg To: linux-wireless@vger.kernel.org Cc: me@bobcopeland.com, Johannes Berg Subject: [PATCH 7/7] wmediumd: don't treat management frames as noack Date: Mon, 23 Mar 2020 16:25:42 +0100 Message-Id: <20200323162245.19716cc94db4.Ib4a8bb12802840a3b9ed7e2e9ca1748a4e77e6ee@changeid> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200323152542.68696-1-johannes@sipsolutions.net> References: <20200323152542.68696-1-johannes@sipsolutions.net> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org From: Johannes Berg It's incorrect to treat management frames as noack, they're retransmitted just like any other frame; fix this. --- wmediumd/wmediumd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/wmediumd/wmediumd.c b/wmediumd/wmediumd.c index 14ea63b6ba69..d756dc4be5b9 100644 --- a/wmediumd/wmediumd.c +++ b/wmediumd/wmediumd.c @@ -321,7 +321,7 @@ static void queue_frame(struct wmediumd *ctx, struct station *station, } frame->signal = snr + NOISE_LEVEL; - noack = frame_is_mgmt(frame) || is_multicast_ether_addr(dest); + noack = is_multicast_ether_addr(dest); double choice = drand48(); -- 2.25.1