Received: by 2002:a25:6193:0:0:0:0:0 with SMTP id v141csp4912755ybb; Tue, 24 Mar 2020 07:36:09 -0700 (PDT) X-Google-Smtp-Source: ADFU+vvzgXI3NVx4BrE+skzOpHo3OuO4uBD9Q/H3KzE2ipd+clBUxNZpJrk+PKzMS23QI+Bb2oH9 X-Received: by 2002:aca:4710:: with SMTP id u16mr3413578oia.108.1585060569492; Tue, 24 Mar 2020 07:36:09 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1585060569; cv=none; d=google.com; s=arc-20160816; b=iiUSQ1hWkx2rNdZlIZ5aM+svvu+Cr+11WoZ6mdHpeLcEDKqaSFw0Keokfy6/N7Yk4I Cot7mqXh0re8Jk+ifdiwDtJRAA1hw4deOdGhDQvm8hIYK7v3I61i2+sIN9GwVCW6wsgW NSpe3uBK2iV6rj8c822aGpXAonQ0GZdo+oIBtXRbxDkGcmkxNSkyRghrO9NvJZNZ1KDB bYh1/X4qIPB2mPo/ypbkGaptnsznx1CVP93SuNxSygFLnll+KkibAXEkjStaEEX1ePbO bCu1N40qf13cJirh68uDzgRvCRR/EesbyvsfjJAYGvIaOgKCQQwZAclgOoiSGUQt5Kyl xikA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:user-agent:message-id :in-reply-to:date:references:subject:cc:to:from:dmarc-filter :dkim-signature; bh=m+xTwLN7kXvmWs1klmW3KOH+aRnvxWgl729kkLtBtDM=; b=lPTtwTaK1ohsAtz0x17+/oWe+wPFwuoKUwBvOroXhGRGVz97MWn2HtNIz3FndF0uHo JC+ZwYIJ2jeAlda5CnSgSFhcYrJbbWYtBDOi7428egUTFuZrPlpY3hLVy0y+DOEvZXpA ZoA61gf5GUYPfNbTGQVlJj/CVhtlBsmWiBU0i9wf/mSC3G1LQRUc5Wqls0lV6zEKdQ5I bvqjMlXI/8w+nc5RLNOeESfr4kfAFNFPhbuX0zBfXo8hl0Uch96oEwXXcGkOak3QvnZ8 GZqpwkipVqiUU+COVC1gI06bqHVe6+0lI+KmAnN1XxWMymGMz6SwsME7pTobu5R6vlys 2y0w== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@mg.codeaurora.org header.s=smtp header.b=hd7+pMVu; spf=pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 193si8797568oie.51.2020.03.24.07.35.49; Tue, 24 Mar 2020 07:36:09 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@mg.codeaurora.org header.s=smtp header.b=hd7+pMVu; spf=pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727742AbgCXOfh (ORCPT + 99 others); Tue, 24 Mar 2020 10:35:37 -0400 Received: from mail27.static.mailgun.info ([104.130.122.27]:43039 "EHLO mail27.static.mailgun.info" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727453AbgCXOfh (ORCPT ); Tue, 24 Mar 2020 10:35:37 -0400 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1585060536; h=Content-Type: MIME-Version: Message-ID: In-Reply-To: Date: References: Subject: Cc: To: From: Sender; bh=m+xTwLN7kXvmWs1klmW3KOH+aRnvxWgl729kkLtBtDM=; b=hd7+pMVuHP/PUw9m37Zyq8O9MlBz78z83EtKSt5TIxhB3p9Mici4JZ4/gfMFqJQWvLeioKBc 5OOnM6dl89gNiy9vlVks8x1C+2ehtmAsKL/cK8p+l6RPS/kPTuuoG0JI7raGUuNRwj8iCz84 AQQkc3dtuV7SnlujY+rMucLyNtg= X-Mailgun-Sending-Ip: 104.130.122.27 X-Mailgun-Sid: WyI3YTAwOSIsICJsaW51eC13aXJlbGVzc0B2Z2VyLmtlcm5lbC5vcmciLCAiYmU5ZTRhIl0= Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by mxa.mailgun.org with ESMTP id 5e7a1aa5.7f7d13efe030-smtp-out-n02; Tue, 24 Mar 2020 14:35:17 -0000 (UTC) Received: by smtp.codeaurora.org (Postfix, from userid 1001) id 3F3CBC433D2; Tue, 24 Mar 2020 14:35:17 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-caf-mail-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=2.0 tests=ALL_TRUSTED,SPF_NONE, URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from potku.adurom.net (88-114-240-156.elisa-laajakaista.fi [88.114.240.156]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: kvalo) by smtp.codeaurora.org (Postfix) with ESMTPSA id BCF07C433CB; Tue, 24 Mar 2020 14:35:15 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org BCF07C433CB Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; spf=none smtp.mailfrom=kvalo@codeaurora.org From: Kalle Valo To: Yu Wang Cc: ath10k@lists.infradead.org, linux-wireless@vger.kernel.org Subject: Re: [PATCH v2 2/2] ath10k: correct legacy rate in tx stats References: <1574147982-3956-1-git-send-email-yyuwang@codeaurora.org> <0101016e82882548-361b3da4-fd9b-4ba9-95b6-a5d782d4a1c8-000000@us-west-2.amazonses.com> Date: Tue, 24 Mar 2020 16:35:13 +0200 In-Reply-To: <0101016e82882548-361b3da4-fd9b-4ba9-95b6-a5d782d4a1c8-000000@us-west-2.amazonses.com> (Yu Wang's message of "Tue, 19 Nov 2019 07:19:50 +0000") Message-ID: <87lfnp4y8u.fsf@kamboji.qca.qualcomm.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Yu Wang writes: > When working in station mode, after connected to a legacy > AP, 11g only, for example, the tx bitrate is incorrect in > output of command 'iw wlan0 link'. > > That's because the legacy tx bitrate value reported by > firmware is not well handled: > For QCA6174, the value represents rate index, but treated > as a real rate; > For QCA9888, the value is real rate, with unit 'Mbps', but > treated as '100kbps'. > > To fix this issue: > 1. Translate the rate index to real rate for QCA6174; > 2. Translate the rate from 'Mbps' to 'kbps' for QCA9888. > > Tested with: > QCA6174 PCIe with firmware WLAN.RM.4.4.1.c3-00031. > QCA6174 SDIO with firmware WLAN.RMH.4.4.1-00029. > QCA9888 PCIe with firmware 10.4-3.9.0.2-00040. What about QCA988X and WCN3990, how do they behave? Does this patch break those? -- https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches