Received: by 2002:a25:6193:0:0:0:0:0 with SMTP id v141csp1541729ybb; Thu, 26 Mar 2020 02:45:10 -0700 (PDT) X-Google-Smtp-Source: ADFU+vs2z+4U8hty5i6DKhDpUlYPPHMCcXlNojAnbsN9ghwDkS4KsTiciBJ7hyP40o36NOMtxKp6 X-Received: by 2002:a9d:6c88:: with SMTP id c8mr5328921otr.272.1585215910296; Thu, 26 Mar 2020 02:45:10 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1585215910; cv=none; d=google.com; s=arc-20160816; b=ploTz8rkzY7pcV5FUBQNOOfRfIBAx4aPyXRlA13d0b3OF8EiVviZw1TXW2ByBotdXq 6B06oPOALz0SKRtCMeYR38jLwFyHICNCxDkmyoJhkU+JVuOONj5O0JEQLD0ZRDQTkqQM 3ZNjH9sXYAL+E4RZj92W5LmiU18HcyhAJv23nXZeyO76LvVypwhg+So4ZjbxVnTOpazS XonnGX7r+fzD6AgGaH3+OwgNtTPvmUkbZ/inXllPt06El8fw8LkcDL1saqL3YPP4Jtzd 1/2ybGMaCA1p0MVOviXwzDLHdgusyudOFqrM8/rdlrHPzK2CE4WziGWMwWG82dd1apx+ JpwQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:date:message-id:user-agent:cc:to :references:in-reply-to:from:subject:content-transfer-encoding :mime-version:dmarc-filter:dkim-signature; bh=qpH3bjwKLqREnf9vNAyia835JUrbonkVHaKkJ/XH9Lk=; b=zZcEH/86fDyq16Ph53OqVhj7bhQ6yXOdkj6iUYs78v9isROEK/qrgJQKeD2ryzlLBc maCH+YINfPS1aHRbvrn5a2g+E78+W9bM4mIPSJO/6XQVq+9Ti+jh2IDH1yvNxZZfI9kb 5a4g7Axad0u4RiAs4Pomw9yQiRe3n4hXrr4R72Fz4j1iQhWxNSBdaI8TFwhEb9V5UfEs 3hzbgH9znZdJ9Zpgd2z1vu5dWGoEvUKpPm1O2/8VrpgugDqn4PMvosuyTo5EkOdNz8xN fWGzFPbGjIBrfE+DnEZfAZd/fUGMGeB/zXmEzVtGirSZLZEqqCHiJu+yJwSeYKrnUJlz Qz7A== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@mg.codeaurora.org header.s=smtp header.b=bjlh0yx0; spf=pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id u125si750157oie.52.2020.03.26.02.44.59; Thu, 26 Mar 2020 02:45:10 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@mg.codeaurora.org header.s=smtp header.b=bjlh0yx0; spf=pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726354AbgCZJo5 (ORCPT + 99 others); Thu, 26 Mar 2020 05:44:57 -0400 Received: from mail26.static.mailgun.info ([104.130.122.26]:59974 "EHLO mail26.static.mailgun.info" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726292AbgCZJo4 (ORCPT ); Thu, 26 Mar 2020 05:44:56 -0400 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1585215896; h=Date: Message-Id: Cc: To: References: In-Reply-To: From: Subject: Content-Transfer-Encoding: MIME-Version: Content-Type: Sender; bh=qpH3bjwKLqREnf9vNAyia835JUrbonkVHaKkJ/XH9Lk=; b=bjlh0yx03GpSiK0A73AGi3piEmNOmz8gZEz3WoIHwYxjEIC0l+R30sDfHfXckOsZt2XGsFjI rSXYVWS2l1xn33k3vgdywAcNftEo/hlZuncwqlsU+6iOASAiei81eG//0zhWffxJdbxH9lfF REFRHRg61kn258WyCLiJOSTIWX0= X-Mailgun-Sending-Ip: 104.130.122.26 X-Mailgun-Sid: WyI3YTAwOSIsICJsaW51eC13aXJlbGVzc0B2Z2VyLmtlcm5lbC5vcmciLCAiYmU5ZTRhIl0= Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by mxa.mailgun.org with ESMTP id 5e7c7992.7feec07238b8-smtp-out-n02; Thu, 26 Mar 2020 09:44:50 -0000 (UTC) Received: by smtp.codeaurora.org (Postfix, from userid 1001) id BF39FC43637; Thu, 26 Mar 2020 09:44:50 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-caf-mail-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=0.5 required=2.0 tests=ALL_TRUSTED,MISSING_DATE, MISSING_MID,SPF_NONE,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from potku.adurom.net (88-114-240-156.elisa-laajakaista.fi [88.114.240.156]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: kvalo) by smtp.codeaurora.org (Postfix) with ESMTPSA id D8D52C433F2; Thu, 26 Mar 2020 09:44:47 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org D8D52C433F2 Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; spf=none smtp.mailfrom=kvalo@codeaurora.org Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [PATCH V3 1/6] brcmfmac: Fix driver crash on USB control transfer timeout From: Kalle Valo In-Reply-To: <1585124429-97371-2-git-send-email-chi-hsien.lin@cypress.com> References: <1585124429-97371-2-git-send-email-chi-hsien.lin@cypress.com> To: Chi-Hsien Lin Cc: linux-wireless@vger.kernel.org, brcm80211-dev-list@broadcom.com, brcm80211-dev-list@cypress.com, Arend van Spriel , Franky Lin , Hante Meuleman , Wright Feng , Raveendran Somu , Chi-hsien Lin User-Agent: pwcli/0.0.0-git (https://github.com/kvalo/pwcli/) Python/2.7.12 Message-Id: <20200326094450.BF39FC43637@smtp.codeaurora.org> Date: Thu, 26 Mar 2020 09:44:50 +0000 (UTC) Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Chi-Hsien Lin wrote: > From: Raveendran Somu > > When the control transfer gets timed out, the error status > was returned without killing that urb, this leads to using > the same urb. This issue causes the kernel crash as the same > urb is sumbitted multiple times. The fix is to kill the > urb for timeout transfer before returning error > > Signed-off-by: Raveendran Somu > Signed-off-by: Chi-hsien Lin 5 patches applied to wireless-drivers-next.git, thanks. 93a5bfbc7cad brcmfmac: Fix driver crash on USB control transfer timeout 78179869dc3f brcmfmac: Fix double freeing in the fmac usb data path bd9944918ceb brcmfmac: fix the incorrect return value in brcmf_inform_single_bss(). 2bc50d8828ad brcmfmac: increase max hanger slots from 1K to 3K in fws layer 7f1d42304d93 brcmfmac: add USB autosuspend feature support -- https://patchwork.kernel.org/patch/11457137/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches