Received: by 2002:a25:6193:0:0:0:0:0 with SMTP id v141csp2367097ybb; Fri, 27 Mar 2020 04:18:08 -0700 (PDT) X-Google-Smtp-Source: ADFU+vspjnTgv5nt9qJMde7dAZ6+BNmpUFPIymCLYarQDxQQs7gj4i/qNElWmkzB/3NmSw/bRA9A X-Received: by 2002:a9d:18f:: with SMTP id e15mr9183568ote.42.1585307888050; Fri, 27 Mar 2020 04:18:08 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1585307888; cv=none; d=google.com; s=arc-20160816; b=v0V44F8QNYABwyC5b7q5FzSSGVVNFEZU6XEy6LsQIGHqdfCJ8lGdUODDnVj3as8psL TH0WC7Si9S0ZXXgB7JBhZsZEEtd8r9BOnXYal/8mbTyqJQLj7eCrd5bHGCxtV6YF05l7 G3XfbkJNIiKkliWvhll2RRNcaLt62fJhx5rQ+F0UCfyFjiGFhc6dcAk2R4JHwTaaIgnO IDJDpVJTnC+KJrnq3ImEplY2TuUecpy+lgQuGgyUrWAS14DToEL7GLdnJiLPh9qFCjkR dbyCm9iNoUrjSRfMpvDyYZWUJwsoZyNlLDy6iUXcxxIe5fJyzbSkz0g/JIXqIG8C9Q06 CcsA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:user-agent:message-id :in-reply-to:date:references:subject:cc:to:from:dmarc-filter :dkim-signature; bh=9LK10OXgzi/rnLsXdPOkiREm+deDTcfebaSPGXR+HEQ=; b=KUSXR/fp96FDgnDT1FPEHpxz6HDpKDP3VldReQVkhn8HrrqwefThbly4xLp6fr0VtE +bibiP09RXOA4Ibelhbw0Z96U7jC5I/yU15Q6rEb0UXPg13kcbILjltqykskIh3qfWXR LOsVx+td8S6lIX0LR04YtiJqKVzX2pFwJVRxupqpAKDpVkIp9ug//3Bf919BAO46IFoA 4v8uS30e581BhuY/QYc790vTuir1pLrOpkCmgqmf4nTDscXsTXkH1E1R2gGTJ8/B+gGk e117E7VlT90BiryPzY5cLfGK/JMxjuXNT5xcwlZRdfcKYiLnBrtUTVeDzOf8ilkLOck6 hKFA== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@mg.codeaurora.org header.s=smtp header.b=XMconDCV; spf=pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id q4si1144166ooo.92.2020.03.27.04.17.50; Fri, 27 Mar 2020 04:18:08 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@mg.codeaurora.org header.s=smtp header.b=XMconDCV; spf=pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726518AbgC0LQI (ORCPT + 99 others); Fri, 27 Mar 2020 07:16:08 -0400 Received: from mail26.static.mailgun.info ([104.130.122.26]:39177 "EHLO mail26.static.mailgun.info" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726379AbgC0LQI (ORCPT ); Fri, 27 Mar 2020 07:16:08 -0400 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1585307768; h=Content-Type: MIME-Version: Message-ID: In-Reply-To: Date: References: Subject: Cc: To: From: Sender; bh=9LK10OXgzi/rnLsXdPOkiREm+deDTcfebaSPGXR+HEQ=; b=XMconDCVrItWeq8VEnjZtvU2UjkbIgEkKpUqi6KwK4Sa9HS35WCEpFZoYsypDnX0w3SsZz/N pzROaILRpopmlyKNQSDN+e4LfzEGSVuGq9GIZLrQY8XILOGR3vMMoGoPp6b2U7jEc7EaR0F0 Z2XeU7E0Q1cofnY1U7nnDnFnFxM= X-Mailgun-Sending-Ip: 104.130.122.26 X-Mailgun-Sid: WyI3YTAwOSIsICJsaW51eC13aXJlbGVzc0B2Z2VyLmtlcm5lbC5vcmciLCAiYmU5ZTRhIl0= Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by mxa.mailgun.org with ESMTP id 5e7de076.7f47fbeeb1f0-smtp-out-n05; Fri, 27 Mar 2020 11:16:06 -0000 (UTC) Received: by smtp.codeaurora.org (Postfix, from userid 1001) id 81092C43636; Fri, 27 Mar 2020 11:16:06 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-caf-mail-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=2.0 tests=ALL_TRUSTED,SPF_NONE autolearn=unavailable autolearn_force=no version=3.4.0 Received: from tynnyri.adurom.net (tynnyri.adurom.net [51.15.11.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: kvalo) by smtp.codeaurora.org (Postfix) with ESMTPSA id D3418C433D2; Fri, 27 Mar 2020 11:16:03 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org D3418C433D2 Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; spf=none smtp.mailfrom=kvalo@codeaurora.org From: Kalle Valo To: Cc: , , , , , , , , Subject: Re: [PATCH v6 00/17] wilc1000: move out of staging References: <20200327063302.20511-1-ajay.kathat@microchip.com> Date: Fri, 27 Mar 2020 13:16:01 +0200 In-Reply-To: <20200327063302.20511-1-ajay.kathat@microchip.com> (Ajay Kathat's message of "Fri, 27 Mar 2020 06:33:07 +0000") Message-ID: <87ftduoxou.fsf@tynnyri.adurom.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org writes: > From: Ajay Singh > > This patch series is to review and move wilc1000 driver out of staging. > Most of the review comments received in [1] & [2] are addressed in the > latest code. Please review and provide your inputs. > > [1]. https://lore.kernel.org/linux-wireless/1537957525-11467-1-git-send-email-ajay.kathat@microchip.com/ > [2]. https://lore.kernel.org/linux-wireless/1562896697-8002-1-git-send-email-ajay.kathat@microchip.com/ > > Changes since v5: > - handle DT binding review comments suggested in below link: > * https://lore.kernel.org/driverdev-devel/20200320175920.GA31641@bogus > - merged latest driver from staging which contains few cleanup patches > and changes to use crc7 from existing library instead of having > private implementation. This is already the third version this month, please avoid spamming the list unnecessarily. What you can do to speed up the acceptance is to get Reviewed-by tags from people, the more I see those the more confident I get about the driver. I will also review this again once I find some free time, but don't know when that will happen. But it would be good to document in the cover letter what commit id are you using as the baseline. That way it's easy to review rest of the changes Greg has applied separately and you don't need to resend the whole driver everytime. -- https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches