Received-SPF: pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8;
 format=flowed
Content-Transfer-Encoding: 8bit
Date:   Mon, 30 Mar 2020 14:52:53 +0530
From:   ssreeela@codeaurora.org
To:     Kalle Valo <kvalo@codeaurora.org>
Cc:     Lei Wang <leiwa@codeaurora.org>, Rick Wu <rwu@codeaurora.org>,
        linux-wireless@vger.kernel.org,
        Sebastian Gottschall <s.gottschall@dd-wrt.com>,
        ath10k@lists.infradead.org
Subject: Re: [PATCH] ath10k: enable VHT160 and VHT80+80 modes
In-Reply-To: <87bloi2g6h.fsf@kamboji.qca.qualcomm.com>
References: <1585148169-2320-1-git-send-email-ssreeela@codeaurora.org>
 <20200326095907.5326BC433BA@smtp.codeaurora.org>
 <812e84a585ed3aeda9aa54f7d2b14e93@codeaurora.org>
 <87bloi2g6h.fsf@kamboji.qca.qualcomm.com>
Message-ID: <158d2bdf5027a494d14cfdd6134b9c6f@codeaurora.org>
User-Agent: Roundcube Webmail/1.3.9
Sender: linux-wireless-owner@vger.kernel.org
Precedence: bulk

On 2020-03-27 16:55, Kalle Valo wrote:
> ssreeela@codeaurora.org writes:
> 
>> On 2020-03-26 15:29, Kalle Valo wrote:
>>> Sowmiya Sree Elavalagan <ssreeela@codeaurora.org> wrote:
>>> 
>>>> From: Lei Wang <leiwa@codeaurora.org>
>>>> 
>>>> Set right channel frequencies in VHT160 mode according to the VHT160
>>>> interoperability workaround added as part of IEEE Std 802.11™-2016 
>>>> in
>>>> "Table 9-252—VHT Operation Information subfields", band_center_freq2
>>>> corresponds to CCFS1 in Table 9-253. Previous implementation
>>>> (band_center_freq2 = 0 for VHT160) is only deprecated.
>>>> 
>>>> Enable VHT80+80 mode and set the proper peer RX nss value for
>>>> VHT160 and
>>>> VHT80+80 mode.
>>>> 
>>>> Based on patches by Sebastian Gottschall:
>>>> 
>>>> https://lkml.kernel.org/r/20180704095444.662-1-s.gottschall@dd-wrt.com
>>>> 
>>>> https://lkml.kernel.org/r/20180704120519.6479-1-s.gottschall@dd-wrt.com
>>>> 
>>>> Tested: qca9984 with firmware ver 10.4-3.10-00047
>>>> 
>>>> Co-developed-by: Sebastian Gottschall <s.gottschall@dd-wrt.com>
>>>> Signed-off-by: Sebastian Gottschall <s.gottschall@dd-wrt.com>
>>>> Co-developed-by: Rick Wu <rwu@codeaurora.org>
>>>> Signed-off-by: Rick Wu <rwu@codeaurora.org>
>>>> Signed-off-by: Lei Wang <leiwa@codeaurora.org>
>>>> Signed-off-by: Sowmiya Sree Elavalagan <ssreeela@codeaurora.org>
>>> 
>>> Fails to build on GCC 8.1. Did you test this?
>>> 
>>> In file included from ./include/asm-generic/bug.h:5,
>>>                  from ./arch/x86/include/asm/bug.h:83,
>>>                  from ./include/linux/bug.h:5,
>>>                  from ./include/net/mac80211.h:16,
>>>                  from drivers/net/wireless/ath/ath10k/mac.h:10,
>>>                  from drivers/net/wireless/ath/ath10k/mac.c:8:
>>> In function 'ath10k_peer_assoc_h_vht',
>>>     inlined from 'ath10k_peer_assoc_prepare' at
>>> drivers/net/wireless/ath/ath10k/mac.c:2790:2:
>>> ./include/linux/compiler.h:350:38: error: call to
>>> '__compiletime_assert_2631' declared with attribute error:
> 
> [...]
> 
>> I checked the build. Build was successful with GCC version 4.8.
>> Will fix the error and update the patch.
> 
> Great, thanks. Here's how I installed GCC 8.1 from crosstool:
> 
> listings: https://www.kernel.org/pub/tools/crosstool/
> 
> wget
> https://www.kernel.org/pub/tools/crosstool/files/bin/x86_64/8.1.0/x86_64-gcc-8.1.0-nolibc-x86_64-linux.tar.xz
> pushd /opt/cross/
> tar -xf ~/tmp/crosstool/x86_64-gcc-8.1.0-nolibc-x86_64-linux.tar.xz
> 
> In top level create GNUMakefile:
> 
> CROSS_COMPILE=/opt/cross/gcc-8.1.0-nolibc/x86_64-linux/bin/x86_64-linux-
> include Makefile

Thanks for the info. Will check the build with GCC 8.1 and resend.

Regards,
Sowmiya Sree