Received-SPF: pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH] brcmfmac: fix wrong location to get firmware feature
To:     Kalle Valo <kvalo@codeaurora.org>,
        Andy Shevchenko <andy.shevchenko@gmail.com>
Cc:     "open list:TI WILINK WIRELES..." <linux-wireless@vger.kernel.org>,
        "open list:BROADCOM BRCM80211 IEEE802.11n WIRELESS DRIVER" 
        <brcm80211-dev-list.pdl@broadcom.com>,
        brcm80211-dev-list@cypress.com,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Arend van Spriel <arend.vanspriel@broadcom.com>,
        Franky Lin <franky.lin@broadcom.com>,
        Hante Meuleman <hante.meuleman@broadcom.com>,
        Chi-Hsien Lin <chi-hsien.lin@cypress.com>,
        Wright Feng <wright.feng@cypress.com>
From:   Jaehoon Chung <jh80.chung@samsung.com>
Message-ID: <40b711a5-869b-1dac-0ac9-e6e59d4bcd52@samsung.com>
Date:   Wed, 1 Apr 2020 19:20:13 +0900
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101
        Thunderbird/60.9.0
MIME-Version: 1.0
In-Reply-To: <87r1xaf8r7.fsf@codeaurora.org>
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset="utf-8"
CMS-TYPE: 101P
DLP-Filter: Pass
References: <CGME20200330052521epcas1p1eedc926d4b11513f8502cf0c90ecf433@epcas1p1.samsung.com>
        <20200330052528.10503-1-jh80.chung@samsung.com>
        <CAHp75Vey9VUSAT6j6NTSXqNUK1vwSqY=aSx3-WPoXgxCK33SDg@mail.gmail.com>
        <87r1xaf8r7.fsf@codeaurora.org>
Sender: linux-wireless-owner@vger.kernel.org
Precedence: bulk

On 3/30/20 7:16 PM, Kalle Valo wrote:
> Andy Shevchenko <andy.shevchenko@gmail.com> writes:
> 
>> On Mon, Mar 30, 2020 at 8:26 AM Jaehoon Chung <jh80.chung@samsung.com> wrote:
>>>
>>> sup_wpa feature is getting after setting feature_disable flag.
>>> If firmware is supported sup_wpa feature,  it's always enabled
>>> regardless of feature_disable flag.
>>>
>>
>>> Fixes: b8a64f0e96c2 ("brcmfmac: support 4-way handshake offloading for WPA/WPA2-PSK")
>>>
>>> Signed-off-by: Jaehoon Chung <jh80.chung@samsung.com>
>>
>> No blank line in between. (Dunno if you need to resend, just wait what
>> maintainer says)
> 
> I can fix that during commit, no need to resend because of this.

Thanks!

BTW, I have a question about brcmfmac's firmware feature.
When i have tested on RPI4, it seems that 4-way handshake offloading feature is using.

If I entered the wrong password, which event is triggered from firmware? 
And how does wpa_supplicant know about wrong key?

I don't have much knowledge about this..but if my analyzing is correct.

<7>[  119.278494] brcmfmac: brcmf_is_nonetwork Processing failed supplicant state: 8
...
<7>[  119.278525] brcmfmac: brcmf_bss_connect_done Report connect result - connection failed
...
<7>[  119.278726] brcmfmac: brcmf_fweh_event_worker event DEAUTH_IND (6) ifidx 0 bsscfg 0 addr 70:5d:cc:6e:b5:xx

<7>[  119.280966] brcmfmac: brcmf_fweh_event_worker event DEAUTH (5) ifidx 0 bsscfg 0 addr 70:5d:cc:6e:b5:xx


firmware is indicating DEAUTH event and driver will be controlled with it, right?
Can someone explain to me in more detail, plz? 

Best Regards,
Jaehoon Chung


>