Received-SPF: pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Message-ID: <693acec3b0c76583e82579e7cc95a22274c3b1da.camel@sipsolutions.net>
Subject: Re: [RFC 3/7] mac80211: handle channel frequency offset
From:   Johannes Berg <johannes@sipsolutions.net>
To:     Thomas Pedersen <thomas@adapt-ip.com>
Cc:     linux-wireless <linux-wireless@vger.kernel.org>
Date:   Wed, 01 Apr 2020 19:53:58 +0200
In-Reply-To: <7b3b34dd-882a-73e7-f857-8e581c3f7bc0@adapt-ip.com>
References: <20200401062150.3324-1-thomas@adapt-ip.com>
         <20200401062150.3324-4-thomas@adapt-ip.com>
         <7fc6331597f53f5d100f3aa7e29434c20cf6fe90.camel@sipsolutions.net>
         <7b3b34dd-882a-73e7-f857-8e581c3f7bc0@adapt-ip.com>
Content-Type: text/plain; charset="UTF-8"
User-Agent: Evolution 3.34.4 (3.34.4-1.fc31) 
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-wireless-owner@vger.kernel.org
Precedence: bulk

On Wed, 2020-04-01 at 10:39 -0700, Thomas Pedersen wrote:
> On 3/31/20 11:59 PM, Johannes Berg wrote:
> > On Tue, 2020-03-31 at 23:21 -0700, Thomas Pedersen wrote:
> > > ie. ignore
> > > for mesh, ibss, HT/VHT specific stuff, TDLS, etc.
> > 
> > This makes sense, but I don't see that you prevent using mesh, ibss and
> > perhaps TDLS on s1g channels?
> > 
> > Or do we not expect drivers/devices that support this, as well as S1G
> > channels?
> 
> Well it's really orthogonal to S1G (maybe a new 2412.5Mhz channel opens
> up :)). We should probably return an error 'if (chan->freq_offset)' or
> so for features which have not yet been tested / implemented for
> frequency offset.

OK, fair enough.

johannes