Received-SPF: pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Fri, 3 Apr 2020 10:59:13 -0400
From:   Tejun Heo <tj@kernel.org>
To:     Wright Feng <wright.feng@cypress.com>
Cc:     Arend Van Spriel <arend.vanspriel@broadcom.com>,
        franky.lin@broadcom.com, hante.meuleman@broadcom.com,
        kvalo@codeaurora.org, chi-hsien.lin@cypress.com,
        linux-wireless@vger.kernel.org, brcm80211-dev-list.pdl@broadcom.com
Subject: Re: [PATCH 3/3] brcmfmac: make setting SDIO workqueue WQ_HIGHPRI a
 module parameter
Message-ID: <20200403145913.GD162390@mtj.duckdns.org>
References: <1584604406-15452-4-git-send-email-wright.feng@cypress.com>
 <40e33702-d37f-085d-a5a7-7f09ae9e2629@broadcom.com>
 <241fd81b-a252-ed86-b93e-6796cf1bce23@cypress.com>
 <20200324182358.GD162390@mtj.duckdns.org>
 <02b42d9f-7ba3-bb7e-36a6-5e141d37d75d@cypress.com>
 <20200325140814.GI162390@mtj.duckdns.org>
 <171122f50d8.279b.9b12b7fc0a3841636cfb5e919b41b954@broadcom.com>
 <c1192351-6f72-6f82-bb2b-9f91266d8aab@cypress.com>
 <20200325151234.GL162390@mtj.duckdns.org>
 <342a1c26-16e6-d824-e421-5f4785f905b8@cypress.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <342a1c26-16e6-d824-e421-5f4785f905b8@cypress.com>
Sender: linux-wireless-owner@vger.kernel.org
Precedence: bulk

On Fri, Mar 27, 2020 at 05:14:29PM +0800, Wright Feng wrote:
> 
> 
> Tejun Heo 於 3/25/2020 11:12 PM 寫道:
> > Hello,
> > 
> > On Wed, Mar 25, 2020 at 11:06:33PM +0800, Wright Feng wrote:
> > > I was trying do that, but the comment of alloc_oredered_workqueue shows that
> > > only WQ_FREEZABLE and WQ_MEM_RECLAIM are meaningful, so...
> > > 
> > > I will measure the throughput with "alloc_ordered_workqueue(NAME,
> > > WQ_HIGHPRI, ...)" to see if WQ_HIGHPRI works with alloc_ordered_workqueue.
> > > Thanks for the suggestion.
> > > 
> > > ---
> > > /**
> > >   * alloc_ordered_workqueue - allocate an ordered workqueue
> > >   * @fmt: printf format for the name of the workqueue
> > >   * @flags: WQ_* flags (only WQ_FREEZABLE and WQ_MEM_RECLAIM are meaningful)
> > >   * @args...: args for @fmt
> > 
> > Yeah, I think the comment is outdated. If it doesn't work as expected, please
> > let me know.
> > 
> It works as expected. With alloc_oredered_workqueue(..., WQ_HIGHPRI, ...),
> the nice value is -20 and throughput result with 43455(11ac) on 1 core 1.6
> Ghz platform is
> Without WQ_HIGGPRI TX/RX: 293/301 (mbps)
> With    WQ_HIGHPRI TX/RX: 293/321 (mbps)

Will update the comment. Thanks.

-- 
tejun