Received-SPF: pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org BEC61C433F2
From:   Kalle Valo <kvalo@codeaurora.org>
To:     <yhchuang@realtek.com>
Cc:     <linux-wireless@vger.kernel.org>, <briannorris@chromium.org>,
        <timlee@realtek.com>
Subject: Re: [PATCH] rtw88: add more check for wowlan pattern
References: <20200406074705.25022-1-yhchuang@realtek.com>
Date:   Mon, 06 Apr 2020 11:16:54 +0300
In-Reply-To: <20200406074705.25022-1-yhchuang@realtek.com>
        (yhchuang@realtek.com's message of "Mon, 6 Apr 2020 15:47:05 +0800")
Message-ID: <87eet1f2q1.fsf@codeaurora.org>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
Sender: linux-wireless-owner@vger.kernel.org
Precedence: bulk

<yhchuang@realtek.com> writes:

> From: Chin-Yen Lee <timlee@realtek.com>
>
> Previously the mask of wowlan pattern is not checked,
> and it may lead to wrong pattern match. We fix it and
> add wildcard type for the pattern whose DA is not masked.
> Besides, if user pattern is an invalid type for us,
> show the error in kernel log, and then wowlan will
> not work.
>
> Signed-off-by: Chin-Yen Lee <timlee@realtek.com>
> Signed-off-by: Yan-Hsuan Chuang <yhchuang@realtek.com>

[...]

> +static inline void ether_addr_copy_mask(u8 *dst, const u8 *src, u8 mask)
> +{
> +	int i;
> +
> +	eth_zero_addr(dst);
> +	for (i = 0; i < ETH_ALEN; i++) {
> +		if (mask & BIT(i))
> +			dst[i] = src[i];
> +	}
> +}

You should not use ether_ prefix within a driver, that is for
include/linux/etherdevice.h. But as you call this only from one place I
recommend just moving the code there and not using a separate function
at all.

-- 
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches